Attachment 12562 Details for Bug 12372 – fix cherry picked for 4-5-test

[patch] fix cherry picked for 4-5-test

ctdb-conn-add-missing-variable-initialization_45t.patch (text/plain), 1.03 KB, created by David Disseldorp on 2016-10-11 09:22:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2016-10-11 09:22:32 UTC

Size: 1.03 KB

patch

obsolete

>From bfe1663098a6c76be9648382c8edae1e5efc9938 Mon Sep 17 00:00:00 2001
>From: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
>Date: Mon, 10 Oct 2016 16:26:05 +0200
>Subject: [PATCH] ctdb-conn: add missing variable initialization
>
>Avoid potential crash in TALLOC_FREE(hdr).
>
>Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>(cherry picked from commit 4194c0797f78293fe48105ce5af70f36a3c233a8)
>---
> source3/lib/ctdbd_conn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c
>index 1f8ac94..118f3a0 100644
>--- a/source3/lib/ctdbd_conn.c
>+++ b/source3/lib/ctdbd_conn.c
>@@ -765,7 +765,7 @@ int ctdbd_db_attach(struct ctdbd_connection *conn,
> int ctdbd_migrate(struct ctdbd_connection *conn, uint32_t db_id, TDB_DATA key)
> {
> 	struct ctdb_req_call_old req;
>-	struct ctdb_req_header *hdr;
>+	struct ctdb_req_header *hdr = NULL;
> 	struct iovec iov[2];
> 	ssize_t nwritten;
> 	int ret;
>-- 
>2.10.0
>

Flags:

asn: review+

Actions: View

Attachments on bug 12372: 12561 | 12562