From 996fa88623efcec073b37e35dd7c924c59bccf27 Mon Sep 17 00:00:00 2001 From: Christof Schmitt Date: Fri, 12 Aug 2016 14:59:07 -0700 Subject: [PATCH] smbd: Fix snapshot query on shares with DFS enabled When DFS is enabled (host msdfs = yes and msdfs root = yes), then SMB clients send create requests in the format \hostname\service\path. Putting the GMT tag as first element breaks the DFS parsing and results in OBJECT_NOT_FOUND for snapshotted files. Fix this by appending the GMT tag to the end of the path. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12150 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sat Aug 13 05:44:39 CEST 2016 on sn-devel-144 (cherry picked from commit f1b42ec778e08875e076df7fdf67dd69bf9b2757) --- source3/smbd/smb2_create.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c index 4c1b81d..75da8a1 100644 --- a/source3/smbd/smb2_create.c +++ b/source3/smbd/smb2_create.c @@ -913,14 +913,14 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx, TALLOC_FREE(fname); fname = talloc_asprintf(state, - "@GMT-%04u.%02u.%02u-%02u.%02u.%02u\\%s", + "%s\\@GMT-%04u.%02u.%02u-%02u.%02u.%02u", + in_name, tm->tm_year + 1900, tm->tm_mon + 1, tm->tm_mday, tm->tm_hour, tm->tm_min, - tm->tm_sec, - in_name); + tm->tm_sec); if (tevent_req_nomem(fname, req)) { return tevent_req_post(req, ev); } -- 2.8.0.rc3.226.g39d4020