Attachment 12194 Details for Bug 11986 – git-am fix proposed for master.

[patch] git-am fix proposed for master.

0001-s3-libsmb-Correctly-trim-a-trailing-character-in-cli.patch (text/plain), 1.52 KB, created by Jeremy Allison on 2016-06-21 22:58:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2016-06-21 22:58:46 UTC

Size: 1.52 KB

patch

obsolete

>From 2ee8bbeccabc5ac2d0cb4185b98a7c1abcf926a5 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Tue, 21 Jun 2016 15:49:27 -0700
>Subject: [PATCH] s3: libsmb: Correctly trim a trailing \\ character in
> cli_smb2_create_fnum_send() when passing a pathname to SMB2 create.
>
>We already trim any leading \\ characters in this function, so this is the simplest place
>to clean the pathname.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11986
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> source3/libsmb/cli_smb2_fnum.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
>index a17d918..c5b1434 100644
>--- a/source3/libsmb/cli_smb2_fnum.c
>+++ b/source3/libsmb/cli_smb2_fnum.c
>@@ -176,6 +176,7 @@ struct tevent_req *cli_smb2_create_fnum_send(TALLOC_CTX *mem_ctx,
> {
> 	struct tevent_req *req, *subreq;
> 	struct cli_smb2_create_fnum_state *state;
>+	size_t fname_len = 0;
> 
> 	req = tevent_req_create(mem_ctx, &state,
> 				struct cli_smb2_create_fnum_state);
>@@ -199,6 +200,17 @@ struct tevent_req *cli_smb2_create_fnum_send(TALLOC_CTX *mem_ctx,
> 		fname++;
> 	}
> 
>+	/* Or end in a '\' */
>+	fname_len = strlen(fname);
>+	if (fname_len > 0 && fname[fname_len-1] == '\\') {
>+		char *new_fname = talloc_strdup(state, fname);
>+		if (tevent_req_nomem(new_fname, req)) {
>+			return tevent_req_post(req, ev);
>+		}
>+		new_fname[fname_len-1] = '\0';
>+		fname = new_fname;
>+	}
>+
> 	subreq = smb2cli_create_send(state, ev,
> 				     cli->conn,
> 				     cli->timeout,
>-- 
>2.7.4
>

Actions: View

Attachments on bug 11986: 12194 | 12199