Attachment 12136 Details for Bug 11934 – git-am fix for 4.4.next, 4.3.next.

[patch] git-am fix for 4.4.next, 4.3.next.

0001-Fix-memory-leak-in-share-mode-locking.patch (text/plain), 1.56 KB, created by Jeremy Allison on 2016-05-27 17:00:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2016-05-27 17:00:12 UTC

Size: 1.56 KB

patch

obsolete

>From bb6550c2881669a60f07f6c31087552b8fcff118 Mon Sep 17 00:00:00 2001
>From: Hemanth Thummala <hemanth.thummala@nutanix.com>
>Date: Tue, 24 May 2016 23:15:04 -0700
>Subject: [PATCH] Fix memory leak in share mode locking.
>
>Not freeing up(and reparenting to NULL context) ndr buffer
>used for TDB updates resulting in huge memory leak when there
>in high volume of opens and closes happening on same object.
>
>Free the buffer before reparenting its parent to NULL context.
>
>https://bugzilla.samba.org/show_bug.cgi?id=11934
>
>Signed-off-by: Hemanth Thummala <hemanth.thummala@nutanix.com>
>Signed-off-by: Saji VR <saji.vr@nutanix.com>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Fri May 27 18:43:31 CEST 2016 on sn-devel-144
>
>(cherry picked from commit 7a725eea25f905fc5f611e8f3d7cfe414d5cf913)
>---
> source3/locking/share_mode_lock.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c
>index fe105e3..4e9de03 100644
>--- a/source3/locking/share_mode_lock.c
>+++ b/source3/locking/share_mode_lock.c
>@@ -441,6 +441,11 @@ static int share_mode_data_destructor(struct share_mode_data *d)
> 	TALLOC_FREE(d->record);
> 
> 	/*
>+	 * Release the dptr as well before reparenting to NULL
>+	 * (in-memory cache) context.
>+	 */
>+	TALLOC_FREE(data.dptr);
>+	/*
> 	 * Reparent d into the in-memory cache so it can be reused if the
> 	 * sequence number matches. See parse_share_modes()
> 	 * for details.
>-- 
>2.8.0.rc3.226.g39d4020
>

Flags:

vl: review+

Actions: View

Attachments on bug 11934: 12136