Attachment 12102 Details for Bug 11842 – patch for git master to remove incorrect check

[patch] patch for git master to remove incorrect check

0001-dsdb-Remove-incorrect-RDN-attid-check-in-replmd_repl.patch (text/plain), 1.34 KB, created by Andrew Bartlett on 2016-05-15 09:33:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2016-05-15 09:33:29 UTC

Size: 1.34 KB

patch

obsolete

>From 98f0257b0307789296150610d4853b3fd3bcd831 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Sun, 15 May 2016 21:31:27 +1200
>Subject: [PATCH] dsdb: Remove incorrect RDN attid check in
> replmd_replPropertyMetaDataCtr1_verify
>
>On windows, the RDN is not sorted last.  Additionally, the check should have been
>against dsdb_attribute_get_attid(), not just ->attributeID_id
>
>Signed-off-by: Andrew Bartlett <abartlet@samba.org>
>---
> source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
>index e9e7318..5ef6f31 100644
>--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
>+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
>@@ -714,12 +714,6 @@ static int replmd_replPropertyMetaDataCtr1_verify(struct ldb_context *ldb,
> 			      ldb_dn_get_linearized(dn));
> 		return LDB_ERR_CONSTRAINT_VIOLATION;
> 	}
>-	if (ctr1->array[ctr1->count - 1].attid != rdn_sa->attributeID_id) {
>-		ldb_debug_set(ldb, LDB_DEBUG_FATAL,
>-			      "No rDN found in replPropertyMetaData for %s!\n",
>-			      ldb_dn_get_linearized(dn));
>-		return LDB_ERR_CONSTRAINT_VIOLATION;
>-	}
> 
> 	/* the objectClass attribute is value 0x00000000, so must be first */
> 	if (ctr1->array[0].attid != DRSUAPI_ATTID_objectClass) {
>-- 
>2.4.11
>

Actions: View

Attachments on bug 11842: 12102