From 593a1c89d4cbbea60697439c2d4cf2afcfeda986 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 10 Apr 2016 12:51:15 +0200 Subject: [PATCH] vfs_catia: Fix bug 11827, memleak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit add_srt should add the mappings to the linked list even if mappings==NULL (the default) Bug: https://bugzilla.samba.org/show_bug.cgi?id=11827 Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme Autobuild-User(master): Ralph Böhme Autobuild-Date(master): Mon Apr 11 14:25:59 CEST 2016 on sn-devel-144 (cherry picked from commit 3e2af1568d150de1cb12fef40580f4880ac787ff) --- source3/modules/vfs_catia.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source3/modules/vfs_catia.c b/source3/modules/vfs_catia.c index c17ffa8..e270c0b 100644 --- a/source3/modules/vfs_catia.c +++ b/source3/modules/vfs_catia.c @@ -141,6 +141,9 @@ static struct share_mapping_entry *add_srt(int snum, const char **mappings) ret->snum = snum; + ret->next = srt_head; + srt_head = ret; + if (mappings) { ret->mappings = (struct char_mappings**) ((unsigned char*) ret + sizeof(struct share_mapping_entry)); @@ -176,9 +179,6 @@ static struct share_mapping_entry *add_srt(int snum, const char **mappings) } } - ret->next = srt_head; - srt_head = ret; - return ret; } -- 2.1.4