Attachment 11836 Details for Bug 11735 – patch for v4-4-test, cherry-picked from master

[patch] patch for v4-4-test, cherry-picked from master

bug-11735.v4-4-test.patch (text/plain), 1.06 KB, created by Michael Adam on 2016-02-15 09:32:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Adam

Created: 2016-02-15 09:32:38 UTC

Size: 1.06 KB

patch

obsolete

>From 5b4de241e6421744d02737a1b8e0200bd27978a3 Mon Sep 17 00:00:00 2001
>From: Michael Adam <obnox@samba.org>
>Date: Wed, 3 Feb 2016 11:41:23 +0100
>Subject: [PATCH] lib:socket: fix CID 1350009 - illegal memory accesses 
> (BUFFER_SIZE_WARNING)
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11735
>
>Pair-Programmed-With: Guenther Deschner <gd@samba.org>
>
>Signed-off-by: Michael Adam <obnox@samba.org>
>Signed-off-by: Guenther Deschner <gd@samba.org>
>Reviewed-by: Uri Simchoni <uri@samba.org>
>(cherry picked from commit 8b36428b195f6e1d1063f1abccb718f2665d271f)
>---
> lib/socket/interfaces.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c
>index cf094f0..847fa62 100644
>--- a/lib/socket/interfaces.c
>+++ b/lib/socket/interfaces.c
>@@ -140,6 +140,11 @@ static void query_iface_speed_from_name(const char *name, uint64_t *speed)
> 		return;
> 	}
> 
>+	if (strlen(name) >= IF_NAMESIZE) {
>+		DBG_ERR("Interface name too long.");
>+		goto done;
>+	}
>+
> 	strncpy(ifr.ifr_name, name, IF_NAMESIZE);
> 
> 	ifr.ifr_data = (void *)&edata;
>-- 
>2.5.0
>

Flags:

obnox: review+
metze: review+
obnox: review? (gd)

Actions: View

Attachments on bug 11735: 11836