Attachment 11820 Details for Bug 11727 – Patch for v4-4-test

[patch] Patch for v4-4-test

skip-dos-v4-4-test.patch (text/plain), 1.17 KB, created by José A. Rivera on 2016-02-09 14:39:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: José A. Rivera

Created: 2016-02-09 14:39:41 UTC

Size: 1.17 KB

patch

obsolete

>From f3eff86b3ff4aca55220e9e5536a5a5a73472a93 Mon Sep 17 00:00:00 2001
>From: "Jose A. Rivera" <jarrpa@samba.org>
>Date: Wed, 3 Feb 2016 20:58:19 -0600
>Subject: [PATCH] s3:smbd:open: Skip redundant call to file_set_dosmode when
> creating a new file.
>
>Signed-off-by: Jose A. Rivera <jarrpa@samba.org>
>Pair-programmed-with: Ira Cooper <ira@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Fri Feb  5 04:37:43 CET 2016 on sn-devel-144
>---
> source3/smbd/open.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/smbd/open.c b/source3/smbd/open.c
>index ed0594b..fa817e4 100644
>--- a/source3/smbd/open.c
>+++ b/source3/smbd/open.c
>@@ -3169,8 +3169,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
> 	}
> 
> 	if (info != FILE_WAS_OPENED) {
>-		/* Files should be initially set as archive */
>-		if (lp_map_archive(SNUM(conn)) ||
>+		/* Overwritten files should be initially set as archive */
>+		if ((info == FILE_WAS_OVERWRITTEN && lp_map_archive(SNUM(conn))) ||
> 		    lp_store_dos_attributes(SNUM(conn))) {
> 			if (!posix_open) {
> 				if (file_set_dosmode(conn, smb_fname,
>-- 
>2.5.0
>

Flags:

jarrpa: review+
jra: review-

Actions: View

Attachments on bug 11727: 11818 | 11819 | 11820 | 11831 | 11832 | 11833 | 11834