Attachment 11814 Details for Bug 11723 – Fix from master

[patch] Fix from master

bug-11723.v4-4-test.patch (text/plain), 1.06 KB, created by Michael Adam on 2016-02-09 00:12:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Adam

Created: 2016-02-09 00:12:43 UTC

Size: 1.06 KB

patch

obsolete

>From 5b0cbec67f5a99459d3a8da3faf6ef75b929191a Mon Sep 17 00:00:00 2001
>From: Michael Adam <obnox@samba.org>
>Date: Wed, 3 Feb 2016 11:28:32 +0100
>Subject: [PATCH] lib:socket: fix CID 1350010 - integer OVERFLOW_BEFORE_WIDEN
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11723
>
>Signed-off-by: Michael Adam <obnox@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Thu Feb  4 00:35:11 CET 2016 on sn-devel-144
>
>(cherry picked from commit 498383afefccb8c7acd93da2c374b5bed1de6e4a)
>---
> lib/socket/interfaces.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c
>index 98341e2..cf094f0 100644
>--- a/lib/socket/interfaces.c
>+++ b/lib/socket/interfaces.c
>@@ -160,7 +160,7 @@ static void query_iface_speed_from_name(const char *name, uint64_t *speed)
> 	if (ret == -1) {
> 		goto done;
> 	}
>-	*speed = (ethtool_cmd_speed(&ecmd)) * 1000 * 1000;
>+	*speed = ((uint64_t)ethtool_cmd_speed(&ecmd)) * 1000 * 1000;
> 
> done:
> 	(void)close(fd);
>-- 
>2.5.0
>

Flags:

obnox: review+
vl: review+

Actions: View

Attachments on bug 11723: 11814