Attachment 11608 Details for Bug 11612 – Patch

[patch] Patch

11612.patch (text/plain), 1.10 KB, created by Volker Lendecke on 2015-11-19 20:28:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2015-11-19 20:28:55 UTC

Size: 1.10 KB

patch

obsolete

>From 7f43009c749f0b6ad47680a2874197c104a09e44 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Thu, 19 Nov 2015 17:00:49 +0100
>Subject: [PATCH] winbind: Don't crash on invalid idmap configs
>
>We should not leave NULL in idmap_domains[]. This will lead to NULL
>ptr deferences in idmap_find_domain().
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=11612
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Thu Nov 19 20:16:44 CET 2015 on sn-devel-104
>
>(cherry picked from commit 7e9aaecec552ca53c50fc0c731419af467f76a00)
>---
> source3/winbindd/idmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source3/winbindd/idmap.c b/source3/winbindd/idmap.c
>index 8de8990..4012e70 100644
>--- a/source3/winbindd/idmap.c
>+++ b/source3/winbindd/idmap.c
>@@ -146,6 +146,7 @@ static bool idmap_found_domain_backend(
> 		if (dom == NULL) {
> 			DBG_NOTICE("Could not init idmap domain %s\n",
> 				   domname);
>+			return false;
> 		}
> 
> 		tmp = talloc_realloc(idmap_domains, idmap_domains,
>-- 
>1.9.1
>

Flags:

jra: review+

Actions: View

Attachments on bug 11612: 11607 | 11608