Attachment 11576 Details for Bug 9912 – Patch for samba-v4-3-test

[patch] Patch for samba-v4-3-test

0001-Changing-log-level-of-two-entries-to-DBG_NOTICE.patch (text/plain), 2.25 KB, created by Marc Muehlfeld on 2015-11-04 18:58:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Muehlfeld

Created: 2015-11-04 18:58:28 UTC

Size: 2.25 KB

patch

obsolete

>From 96dca9b8e747b0d778b50fd075d08bbb33f60243 Mon Sep 17 00:00:00 2001
>From: Marc Muehlfeld <mmuehlfeld@samba.org>
>Date: Tue, 3 Nov 2015 10:09:13 +0100
>Subject: [PATCH] Changing log level of two entries to DBG_NOTICE
>
>On domain members using RFC2307, machine acccounts without an uidNumber
>attribute are not retrieved via idmap_ad. This leads to many of the following
>two error messages:
>   Username DOMAIN\machineaccountname$ is invalid on this system
>and
>   Failed to map kerberos principal to system user (NT_STATUS_LOGON_FAILURE)
>Machine accounts don't have an uidNumber attribute, if not set manually. To
>avoid flooding the logs, setting message from debug level 1 to DBG_NOTICE.
>
>Bugreport: https://bugzilla.samba.org/show_bug.cgi?id=9912
>
>Signed-off-by: Marc Muehlfeld <mmuehlfeld@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Wed Nov  4 00:46:15 CET 2015 on sn-devel-104
>
>(cherry picked from commit 18879dab9affffd79a647a4de697512c03e04425)
>---
> source3/auth/auth_generic.c | 4 ++--
> source3/auth/user_krb5.c    | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/source3/auth/auth_generic.c b/source3/auth/auth_generic.c
>index 584b52f..74eb2fa 100644
>--- a/source3/auth/auth_generic.c
>+++ b/source3/auth/auth_generic.c
>@@ -95,8 +95,8 @@ static NTSTATUS auth3_generate_session_info_pac(struct auth4_context *auth_ctx,
> 					     &ntuser, &ntdomain,
> 					     &username, &pw);
> 	if (!NT_STATUS_IS_OK(status)) {
>-		DEBUG(1, ("Failed to map kerberos principal to system user "
>-			  "(%s)\n", nt_errstr(status)));
>+		DBG_NOTICE("Failed to map kerberos principal to system user "
>+			  "(%s)\n", nt_errstr(status));
> 		status = NT_STATUS_ACCESS_DENIED;
> 		goto done;
> 	}
>diff --git a/source3/auth/user_krb5.c b/source3/auth/user_krb5.c
>index 7442ea4..2b009ba 100644
>--- a/source3/auth/user_krb5.c
>+++ b/source3/auth/user_krb5.c
>@@ -160,8 +160,8 @@ NTSTATUS get_user_from_kerberos_info(TALLOC_CTX *mem_ctx,
> 
> 		/* extra sanity check that the guest account is valid */
> 		if (!pw) {
>-			DEBUG(1, ("Username %s is invalid on this system\n",
>-				  fuser));
>+			DBG_NOTICE("Username %s is invalid on this system\n",
>+				  fuser);
> 			return NT_STATUS_LOGON_FAILURE;
> 		}
> 	}
>-- 
>2.5.0
>

Flags:

jra: review+

Actions: View

Attachments on bug 9912: 8930 | 11570 | 11575 | 11576 | 11577