Attachment 11564 Details for Bug 11569 – patch (1 or 2) file for 4.2.x

[patch] patch (1 or 2) file for 4.2.x

0001-Prevent-null-ptr-access-by-returning-error-if-no-cre.patch (text/plain), 1.27 KB, created by Noel Power on 2015-11-02 10:30:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Noel Power

Created: 2015-11-02 10:30:00 UTC

Size: 1.27 KB

patch

obsolete

>From 4198f37bed021565a1abf055943e45234ebf0725 Mon Sep 17 00:00:00 2001
>From: Noel Power <noel.power@suse.com>
>Date: Thu, 22 Oct 2015 12:37:17 +0100
>Subject: [PATCH 1/2] Prevent null ptr access by returning error if no creds
> available
>
>Prevent rpccli_netlogon_network_logon/rpccli_netlogon_password_logon
>being called with 'NULL' credentials
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569
>Signed-off-by: Noel Power <noel.power@suse.com>
>---
> source3/winbindd/winbindd_pam.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
>index bed2220..0b8ad01 100644
>--- a/source3/winbindd/winbindd_pam.c
>+++ b/source3/winbindd/winbindd_pam.c
>@@ -1367,8 +1367,10 @@ static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
> 			return result;
> 		}
> 		netr_attempts = 0;
>-
>-		if (interactive && username != NULL && password != NULL) {
>+		if (domain->conn.netlogon_creds == NULL) {
>+			DEBUG(3, ("No security credentials available.\n"));
>+			result = NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
>+		} else if (interactive && username != NULL && password != NULL) {
> 			result = rpccli_netlogon_password_logon(domain->conn.netlogon_creds,
> 								netlogon_pipe->binding_handle,
> 								mem_ctx,
>-- 
>2.1.4
>

Actions: View

Attachments on bug 11569: 11529 | 11564 | 11565 | 11571 | 11581 | 11582 | 11583 | 11584 | 11588