From ddb180be53d751eb50199532e7d9abf1f02c093a Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 6 Oct 2015 16:10:43 +0200 Subject: [PATCH] smbd: Send SMB2 oplock breaks unencrypted This is not what Windows server does, but it seems that Windows clients expect. Windows->Windows never runs into this issue, because an encryption-enabled SMB3 connection will always use leases, and lease breaks *are* unencrypted... You can reproduce the issue Windows->Windows by disabling leases on the Windows server. Disable leases using the registry key: HKLM\SYSTEM\CurrentControlSet\Services\LanmanServer\DisableLeasing Dochelp confirmed that this is a valid workaround for Windows clients dropping encrypted oplock breaks. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11570 Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sat Oct 24 05:01:32 CEST 2015 on sn-devel-104 (cherry picked from commit 0a924d13cf4bb570cce3955cf0de9d8678b37dbe) --- source3/smbd/smb2_server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c index 2ea997e..40f3f2d 100644 --- a/source3/smbd/smb2_server.c +++ b/source3/smbd/smb2_server.c @@ -2976,7 +2976,7 @@ NTSTATUS smbd_smb2_send_oplock_break(struct smbXsrv_connection *xconn, SBVAL(body, 0x08, op->global->open_persistent_id); SBVAL(body, 0x10, op->global->open_volatile_id); - return smbd_smb2_send_break(xconn, session, tcon, body, sizeof(body)); + return smbd_smb2_send_break(xconn, NULL, NULL, body, sizeof(body)); } NTSTATUS smbd_smb2_send_lease_break(struct smbXsrv_connection *xconn, -- 2.6.0.rc2.230.g3dd15c0