Attachment 11465 Details for Bug 11528 – git-am fix for 4.3.next, 4.2.next.

[patch] git-am fix for 4.3.next, 4.2.next.

0001-net-fix-a-crash-with-net-ads-keytab-create.patch (text/plain), 1.22 KB, created by Jeremy Allison on 2015-09-25 20:55:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2015-09-25 20:55:30 UTC

Size: 1.22 KB

patch

obsolete

>From 5909525594de399120084358d6b816f007279301 Mon Sep 17 00:00:00 2001
>From: Uri Simchoni <urisimchoni@gmail.com>
>Date: Wed, 23 Sep 2015 14:45:47 +0300
>Subject: [PATCH] net: fix a crash with net ads keytab create
>
>Fix a crash that happens when executing "net ads keytab create"
>and the machine account in AD does not have setvice principal names
>attached to it.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11528
>
>Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>(cherry picked from commit e224e622971853bddbe24df717ea5dcddef71b89)
>---
> source3/libads/ldap.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
>index 70301de..6031b42 100644
>--- a/source3/libads/ldap.c
>+++ b/source3/libads/ldap.c
>@@ -2004,6 +2004,13 @@ ADS_STATUS ads_get_service_principal_names(TALLOC_CTX *mem_ctx,
> 				      res,
> 				      "servicePrincipalName",
> 				      num_spns);
>+	if (*spn_array == NULL) {
>+		DEBUG(1, ("Host account for %s does not have service principal "
>+			  "names.\n",
>+			  machine_name));
>+		status = ADS_ERROR(LDAP_NO_SUCH_OBJECT);
>+		goto done;
>+	}
> 
> done:
> 	ads_msgfree(ads, res);
>-- 
>2.1.4
>

Flags:

uri: review+

Actions: View

Attachments on bug 11528: 11458 | 11465