Attachment 1146 Details for Bug 2591 – patch

[patch] patch

look (text/plain), 1.08 KB, created by Jeremy Allison on 2005-04-12 10:28:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2005-04-12 10:28:59 UTC

Size: 1.08 KB

patch

obsolete

>Index: smbd/posix_acls.c
>===================================================================
>--- smbd/posix_acls.c	(revision 6315)
>+++ smbd/posix_acls.c	(working copy)
>@@ -3874,11 +3874,15 @@
> 		}
> 	}
> 
>-	/* If we get here we know ret == 0. */
>-	SMB_ASSERT(ret == 0);
>+	/* If ret is -1 here we didn't match on the user entry or
>+	   supplemental group entries. */
>+	
>+	DEBUG(10,("check_posix_acl_group_write: ret = %d before check_stat:\n", ret));
> 
>   check_stat:
> 
>+	/* Do we match on the owning group entry ? */
>+
> 	for (i = 0; i < current_user.ngroups; i++) {
> 		if (current_user.groups[i] == psbuf->st_gid) {
> 			ret = (psbuf->st_mode & S_IWGRP) ? 1 : 0;
>@@ -3889,14 +3893,15 @@
> 	}
> 
> 	if (i == current_user.ngroups) {
>-		SMB_ASSERT(ret != 1);
> 		DEBUG(10,("check_posix_acl_group_write: file %s \
>-failed to match on user or group in token.\n", fname ));
>+failed to match on user or group in token (ret = %d).\n", fname, ret ));
> 	}
> 
>   done:
> 
> 	SMB_VFS_SYS_ACL_FREE_ACL(conn, posix_acl);
>+
>+	DEBUG(10,("check_posix_acl_group_write: file %s returning (ret = %d).\n", fname, ret ));
> 	return ret;
> }
>

Actions: View

Attachments on bug 2591: 1145 | 1146