The Samba-Bugzilla – Attachment 11370 Details for
Bug 11427
nmbd incorrectly matches netbios names as own name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am fix for 4.3.0, 4.2.next, 4.1.next.
0001-s3-util-Compare-the-maximum-allowed-length-of-a-NetB.patch (text/plain), 1013 bytes, created by
Jeremy Allison
on 2015-08-25 21:19:37 UTC
(
hide
)
Description:
git-am fix for 4.3.0, 4.2.next, 4.1.next.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2015-08-25 21:19:37 UTC
Size:
1013 bytes
patch
obsolete
>From 4e178ed498c594ffcd5592d0b792d47b064b9586 Mon Sep 17 00:00:00 2001 >From: Roel van Meer <roel@1afa.com> >Date: Tue, 4 Aug 2015 16:50:43 +0200 >Subject: [PATCH] s3-util: Compare the maximum allowed length of a NetBIOS name > >This fixes a problem where is_myname() returns true if one of our names >is a substring of the specified name. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=11427 > >Reviewed-by: Jeremy Allison <jra@samba.org> >Reviewed-by: Andreas Schneider <asn@samba.org> >--- > source3/lib/util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/source3/lib/util.c b/source3/lib/util.c >index 2fd2b6b..d38d53a 100644 >--- a/source3/lib/util.c >+++ b/source3/lib/util.c >@@ -1198,7 +1198,7 @@ bool is_myname(const char *s) > for (n=0; my_netbios_names(n); n++) { > const char *nbt_name = my_netbios_names(n); > >- if (strncasecmp_m(nbt_name, s, strlen(nbt_name)) == 0) { >+ if (strncasecmp_m(nbt_name, s, MAX_NETBIOSNAME_LEN-1) == 0) { > ret=True; > break; > } >-- >2.5.0.457.gab17608 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
jra
:
review?
(
gd
)
jra
:
review?
(
obnox
)
jra
:
review?
(
ira
)
vl
:
review+
Actions:
View
Attachments on
bug 11427
:
11306
| 11370