The Samba-Bugzilla – Attachment 11306 Details for
Bug 11427
nmbd incorrectly matches netbios names as own name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Compare the maximum allowed length of a NetBIOS name
0001-s3-util-Compare-the-maximum-allowed-length-of-a-NetB.patch (text/plain), 859 bytes, created by
Roel van Meer
on 2015-08-04 14:57:54 UTC
(
hide
)
Description:
Compare the maximum allowed length of a NetBIOS name
Filename:
MIME Type:
Creator:
Roel van Meer
Created:
2015-08-04 14:57:54 UTC
Size:
859 bytes
patch
obsolete
>From dec426b8d207378952799895368401362250cc23 Mon Sep 17 00:00:00 2001 >From: Roel van Meer <roel@1afa.com> >Date: Tue, 4 Aug 2015 16:50:43 +0200 >Subject: [PATCH] s3-util: Compare the maximum allowed length of a NetBIOS name > >This fixes a problem where is_myname() returns true if one of our names >is a substring of the specified name. >--- > source3/lib/util.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/source3/lib/util.c b/source3/lib/util.c >index 2fd2b6b..d38d53a 100644 >--- a/source3/lib/util.c >+++ b/source3/lib/util.c >@@ -1198,7 +1198,7 @@ bool is_myname(const char *s) > for (n=0; my_netbios_names(n); n++) { > const char *nbt_name = my_netbios_names(n); > >- if (strncasecmp_m(nbt_name, s, strlen(nbt_name)) == 0) { >+ if (strncasecmp_m(nbt_name, s, MAX_NETBIOSNAME_LEN-1) == 0) { > ret=True; > break; > } >-- >1.7.1 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=11306">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 11427
: 11306 |
11370