From dec426b8d207378952799895368401362250cc23 Mon Sep 17 00:00:00 2001 From: Roel van Meer Date: Tue, 4 Aug 2015 16:50:43 +0200 Subject: [PATCH] s3-util: Compare the maximum allowed length of a NetBIOS name This fixes a problem where is_myname() returns true if one of our names is a substring of the specified name. --- source3/lib/util.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/source3/lib/util.c b/source3/lib/util.c index 2fd2b6b..d38d53a 100644 --- a/source3/lib/util.c +++ b/source3/lib/util.c @@ -1198,7 +1198,7 @@ bool is_myname(const char *s) for (n=0; my_netbios_names(n); n++) { const char *nbt_name = my_netbios_names(n); - if (strncasecmp_m(nbt_name, s, strlen(nbt_name)) == 0) { + if (strncasecmp_m(nbt_name, s, MAX_NETBIOSNAME_LEN-1) == 0) { ret=True; break; } -- 1.7.1