Attachment 11269 Details for Bug 11404 – patch for 4.1

[patch] patch for 4.1

41.patch (text/plain), 1.07 KB, created by Andreas Schneider on 2015-07-17 12:32:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2015-07-17 12:32:30 UTC

Size: 1.07 KB

patch

obsolete

>From 6607925aa0fae4e3d2c5084e11f699f16912b847 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Fri, 17 Jul 2015 10:54:17 +0200
>Subject: [PATCH] s3-auth: Fix a possible null pointer dereference
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11404
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Alexander Bokovoy <ab@samba.org>
>
>(cherry picked from commit 109ff388fd5e1306189d680a8f964a69374f1b01)
>---
> source3/auth/auth_ntlmssp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/source3/auth/auth_ntlmssp.c b/source3/auth/auth_ntlmssp.c
>index f99bd44..dae5f77 100644
>--- a/source3/auth/auth_ntlmssp.c
>+++ b/source3/auth/auth_ntlmssp.c
>@@ -153,7 +153,9 @@ NTSTATUS auth3_check_password(struct auth4_context *auth4_context,
> 							&server_info,
> 							user_info->client.account_name,
> 							user_info->client.domain_name);
>-		*server_returned_info = talloc_steal(mem_ctx, server_info);
>+		if (NT_STATUS_IS_OK(nt_status)) {
>+			*server_returned_info = talloc_steal(mem_ctx, server_info);
>+		}
> 		return nt_status;
> 	}
> 
>-- 
>2.4.5
>

Flags:

ab: review+

Actions: View

Attachments on bug 11404: 11268 | 11269