From f33914d559ad525bb49de510b20accf3d4c1d221 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Fri, 17 Jul 2015 10:54:17 +0200 Subject: [PATCH] s3-auth: Fix a possible null pointer dereference BUG: https://bugzilla.samba.org/show_bug.cgi?id=11404 Signed-off-by: Andreas Schneider Reviewed-by: Alexander Bokovoy (cherry picked from commit 109ff388fd5e1306189d680a8f964a69374f1b01) --- source3/auth/auth_ntlmssp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source3/auth/auth_ntlmssp.c b/source3/auth/auth_ntlmssp.c index 14bce62..6d378c4 100644 --- a/source3/auth/auth_ntlmssp.c +++ b/source3/auth/auth_ntlmssp.c @@ -198,7 +198,9 @@ NTSTATUS auth3_check_password(struct auth4_context *auth4_context, user_info->client.account_name, user_info->client.domain_name, &server_info); - *server_returned_info = talloc_steal(mem_ctx, server_info); + if (NT_STATUS_IS_OK(nt_status)) { + *server_returned_info = talloc_steal(mem_ctx, server_info); + } return nt_status; } -- 2.4.5