From 511bd7f42abe4e0f61da76941d93407ff85755e9 Mon Sep 17 00:00:00 2001 From: Arvid Requate Date: Wed, 8 Jul 2015 11:48:39 +0200 Subject: [PATCH] s4-dsdb/netlogon: allow missing ntver in cldap ping Seen in the wild: Huawai storage array performs the initial CLDAP ping without NtVer in the filter. Samba doesn't send a searchResEntry in this case, only the searchResResult (success). [MS-ADTS] sect. 6.3.3.2 "Domain Controller Response to an LDAP Ping" specifies that in this case the DC should answer normally with a NETLOGON_SAM_LOGON_RESPONSE_NT40 structure. Signed-off-by: Arvid Requate --- source4/dsdb/samdb/ldb_modules/netlogon.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source4/dsdb/samdb/ldb_modules/netlogon.c b/source4/dsdb/samdb/ldb_modules/netlogon.c index a381da8..953a580 100644 --- a/source4/dsdb/samdb/ldb_modules/netlogon.c +++ b/source4/dsdb/samdb/ldb_modules/netlogon.c @@ -449,10 +449,6 @@ NTSTATUS parse_netlogon_request(struct ldb_parse_tree *tree, *domain = lpcfg_dnsdomain(lp_ctx); } - if (*version == -1) { - goto failed; - } - return NT_STATUS_OK; failed: -- 2.1.4