Attachment 11190 Details for Bug 11081 – Patches for v4-1-test

[patch] Patches for v4-1-test

tmp41.diff.txt (text/plain), 2.28 KB, created by Stefan Metzmacher on 2015-06-24 09:59:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2015-06-24 09:59:22 UTC

Size: 2.28 KB

patch

obsolete

>From 8635bc24b778196171d1b7ede91fd5ac11d450d4 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Wed, 24 Jun 2015 11:46:33 +0200
>Subject: [PATCH] s3:winbindd: make sure we pass a valid server to
> rpccli_netlogon_sam_network_logon*()
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11081
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>---
> source3/winbindd/winbindd_pam.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
>index c356686..10d30d2 100644
>--- a/source3/winbindd/winbindd_pam.c
>+++ b/source3/winbindd/winbindd_pam.c
>@@ -1212,7 +1212,6 @@ static NTSTATUS winbindd_dual_auth_passdb(TALLOC_CTX *mem_ctx,
> static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
> 					    TALLOC_CTX *mem_ctx,
> 					    uint32_t logon_parameters,
>-					    const char *server,
> 					    const char *username,
> 					    const char *domainname,
> 					    const char *workstation,
>@@ -1336,7 +1335,7 @@ static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
> 					netlogon_pipe,
> 					mem_ctx,
> 					logon_parameters,
>-					server,		/* server name */
>+					domain->dcname,	/* server name */
> 					username,	/* user name */
> 					domainname,	/* target domain */
> 					workstation,	/* workstation */
>@@ -1350,7 +1349,7 @@ static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
> 					netlogon_pipe,
> 					mem_ctx,
> 					logon_parameters,
>-					server,		/* server name */
>+					domain->dcname,	/* server name */
> 					username,	/* user name */
> 					domainname,	/* target domain */
> 					workstation,	/* workstation */
>@@ -1513,7 +1512,6 @@ static NTSTATUS winbindd_dual_pam_auth_samlogon(TALLOC_CTX *mem_ctx,
> 	result = winbind_samlogon_retry_loop(domain,
> 					     mem_ctx,
> 					     0,
>-					     domain->dcname,
> 					     name_user,
> 					     name_domain,
> 					     lp_netbios_name(),
>@@ -1936,7 +1934,6 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
> 	result = winbind_samlogon_retry_loop(domain,
> 					     state->mem_ctx,
> 					     state->request->data.auth_crap.logon_parameters,
>-					     domain->dcname,
> 					     name_user,
> 					     name_domain,
> 					     /* Bug #3248 - found by Stefan Burkei. */
>-- 
>1.9.1
>

Flags:

gd: review+

Actions: View

Attachments on bug 11081: 10681 | 11188 | 11189 | 11190 | 11191