Attachment 11041 Details for Bug 11267 – Slight change to deal with context already expired.

[patch] Slight change to deal with context already expired.

0001-libads-record-service-ticket-endtime-for-sealed-ldap.patch (text/plain), 2.00 KB, created by Jeremy Allison on 2015-05-11 17:28:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2015-05-11 17:28:56 UTC

Size: 2.00 KB

patch

obsolete

>From daa6c09b7a2931aacd531bb49daf6e47e843a059 Mon Sep 17 00:00:00 2001
>From: Uri Simchoni <urisimchoni@gmail.com>
>Date: Sat, 9 May 2015 22:59:17 +0300
>Subject: [PATCH] libads: record service ticket endtime for sealed ldap
> connections
>
>When a ticket is obtained for binding a signed/sealed ldap connection,
>its liftime should be recorded in the ads struct, in order to enable
>reuse of the connection.
>
>Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>---
> source3/libads/sasl.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
>diff --git a/source3/libads/sasl.c b/source3/libads/sasl.c
>index ce3740f..af50186 100644
>--- a/source3/libads/sasl.c
>+++ b/source3/libads/sasl.c
>@@ -458,6 +458,8 @@ static ADS_STATUS ads_sasl_spnego_gsskrb5_bind(ADS_STRUCT *ads, const gss_name_t
> 	DATA_BLOB unwrapped;
> 	DATA_BLOB wrapped;
> 	struct berval cred, *scred = NULL;
>+	uint32_t context_validity;
>+	time_t context_endtime = 0;
> 
> 	status = ads_init_gssapi_cred(ads, &gss_cred);
> 	if (!ADS_ERR_OK(status)) {
>@@ -652,6 +654,23 @@ static ADS_STATUS ads_sasl_spnego_gsskrb5_bind(ADS_STRUCT *ads, const gss_name_t
> 		goto failed;
> 	}
> 
>+	gss_rc =
>+	    gss_context_time(&minor_status, context_handle, &context_validity);
>+	if (gss_rc == 0) {
>+		if (context_validity != 0) {
>+			context_endtime = time(NULL) + context_validity;
>+			DEBUG(10, ("context (service ticket) valid for "
>+				"%u seconds\n",
>+				context_validity));
>+		} else {
>+			DEBUG(10, ("context (service ticket) expired\n"));
>+		}
>+	} else {
>+		DEBUG(1, ("gss_context_time failed (%d,%u) -"
>+			  " this will be a one-time context\n",
>+			  gss_rc, minor_status));
>+	}
>+
> 	if (ads->ldap.wrap_type > ADS_SASLWRAP_TYPE_PLAIN) {
> 		uint32_t max_msg_size = ADS_SASL_WRAPPING_OUT_MAX_WRAPPED;
> 
>@@ -677,6 +696,7 @@ static ADS_STATUS ads_sasl_spnego_gsskrb5_bind(ADS_STRUCT *ads, const gss_name_t
> 		context_handle = GSS_C_NO_CONTEXT;
> 	}
> 
>+	ads->auth.tgs_expire = context_endtime;
> 	status = ADS_SUCCESS;
> 
> failed:
>-- 
>2.2.0.rc0.207.ga3a616c
>

Actions: View

Attachments on bug 11267: 11039 | 11041 | 11048 | 11051