Attachment 10968 Details for Bug 11226 – Patch to fix termination of asynchronous connections with pending calls

[patch] Patch to fix termination of asynchronous connections with pending calls

0001-Add-DCERPC-flag-to-call-unbind-hooks-without-destroy.patch (text/plain), 2.70 KB, created by Julien Kerihuel (mail address dead) on 2015-04-20 10:36:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julien Kerihuel (mail address dead)

Created: 2015-04-20 10:36:14 UTC

Size: 2.70 KB

patch

obsolete

>From a3528f8df5eb36aab6b814fd8511e3849b242a23 Mon Sep 17 00:00:00 2001
>From: Julien Kerihuel <j.kerihuel@openchange.org>
>Date: Mon, 6 Apr 2015 11:26:58 +0200
>Subject: [PATCH] Add DCERPC flag to call unbind hooks without destroying the
> connection itself upon termination of a connection with outstanding pending
> calls.
>
>---
> source4/rpc_server/dcerpc_server.c | 21 +++++++++++++++++++++
> source4/rpc_server/dcerpc_server.h |  1 +
> 2 files changed, 22 insertions(+)
>
>diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c
>index a8785b0..dbdc67f 100644
>--- a/source4/rpc_server/dcerpc_server.c
>+++ b/source4/rpc_server/dcerpc_server.c
>@@ -504,6 +504,7 @@ static int dcesrv_connection_context_destructor(struct dcesrv_connection_context
> 
> 	if (c->iface && c->iface->unbind) {
> 		c->iface->unbind(c, c->iface);
>+		c->iface = NULL;
> 	}
> 
> 	return 0;
>@@ -620,6 +621,10 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
> 		extra_flags |= DCERPC_PFC_FLAG_CONC_MPX;
> 	}
> 
>+	if (call->state_flags & DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL) {
>+		call->context->conn->state_flags |= DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL;
>+	}
>+
> 	/* handle any authentication that is being requested */
> 	if (!dcesrv_auth_bind(call)) {
> 		talloc_free(call->context);
>@@ -839,6 +844,10 @@ static NTSTATUS dcesrv_alter(struct dcesrv_call_state *call)
> 		}
> 	}
> 
>+	if (call->state_flags & DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL) {
>+		call->context->conn->state_flags |= DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL;
>+	}
>+
> 	/* setup a alter_resp */
> 	dcesrv_init_hdr(&pkt, lpcfg_rpc_big_endian(call->conn->dce_ctx->lp_ctx));
> 	pkt.auth_length = 0;
>@@ -1378,6 +1387,18 @@ static void dcesrv_cleanup_broken_connections(struct dcesrv_context *dce_ctx)
> 		cur = next;
> 		next = cur->next;
> 
>+		if (cur->state_flags & DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL) {
>+			struct dcesrv_connection_context *context_cur, *context_next;
>+
>+			context_next = cur->contexts;
>+			while (context_next != NULL) {
>+				context_cur = context_next;
>+				context_next = context_cur->next;
>+
>+				dcesrv_connection_context_destructor(context_cur);
>+			}
>+		}
>+
> 		dcesrv_terminate_connection(cur, cur->terminate);
> 	}
> }
>diff --git a/source4/rpc_server/dcerpc_server.h b/source4/rpc_server/dcerpc_server.h
>index 1bf187a..9a697ce 100644
>--- a/source4/rpc_server/dcerpc_server.h
>+++ b/source4/rpc_server/dcerpc_server.h
>@@ -102,6 +102,7 @@ struct dcesrv_call_state {
> #define DCESRV_CALL_STATE_FLAG_ASYNC (1<<0)
> #define DCESRV_CALL_STATE_FLAG_MAY_ASYNC (1<<1)
> #define DCESRV_CALL_STATE_FLAG_MULTIPLEXED (1<<3)
>+#define DCESRV_CALL_STATE_FLAG_PROCESS_PENDING_CALL (1<<4)
> 	uint32_t state_flags;
> 
> 	/* the time the request arrived in the server */
>-- 
>1.9.1
>

Actions: View

Attachments on bug 11226: 10968 | 10971 | 10975