From 9357f6ca2f0166be3122efdb72330e256d7c87ab Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Wed, 1 Apr 2015 01:03:13 +0200 Subject: [PATCH] spoolss: purge the printer name cache on name change MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the name cache is only cleared on printer deletion. This means that if a printer undergoes a name change, the old name remains in the cache and can be subsequently used incorrecly if another printer takes the same name as the old. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11210 Reported-by: Franz Pförtsch Signed-off-by: David Disseldorp Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Apr 14 05:37:50 CEST 2015 on sn-devel-104 (cherry picked from commit a97507a9a7ba01beead6a621e1210618e93a9f9c) --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index 8372c43..09d353f 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -6328,6 +6328,9 @@ static WERROR update_dsspooler(TALLOC_CTX *mem_ctx, snum, printer->sharename ? printer->sharename : ""); } + + /* name change, purge any cache entries for the old */ + prune_printername_cache(); } if (force_update || !strequal(printer->printername, old_printer->printername)) { @@ -6353,6 +6356,9 @@ static WERROR update_dsspooler(TALLOC_CTX *mem_ctx, notify_printer_printername(server_event_context(), msg_ctx, snum, p ? p : ""); } + + /* name change, purge any cache entries for the old */ + prune_printername_cache(); } if (force_update || !strequal(printer->portname, old_printer->portname)) { -- 2.1.4