Attachment 10905 Details for Bug 11177 – Fixing error message in libsmbcilent saying no talloc stack frame

[patch] Fixing error message in libsmbcilent saying no talloc stack frame

0001-Fixing-log-message-in-libsmbclient-coming-due-to-mis.patch (text/plain), 1.83 KB, created by hargagan on 2015-03-23 07:23:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: hargagan

Created: 2015-03-23 07:23:12 UTC

Size: 1.83 KB

patch

obsolete

>From bef9d040c72956cb1b606e8a8a3e8db029eda6b2 Mon Sep 17 00:00:00 2001
>From: Har Gagan Sahai <SHarGagan@novell.com>
>Date: Wed, 6 Aug 2014 14:32:35 +0530
>Subject: [PATCH 1/1] Fixing log message in libsmbclient coming due to missing
> talloc frame.
>
>Signed-off-by: Har Gagan Sahai <SHarGagan@novell.com>
>---
> source3/libsmb/clifsinfo.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/source3/libsmb/clifsinfo.c b/source3/libsmb/clifsinfo.c
>index 376c4f5..4e52cca 100644
>--- a/source3/libsmb/clifsinfo.c
>+++ b/source3/libsmb/clifsinfo.c
>@@ -338,11 +338,12 @@ NTSTATUS cli_get_fs_attr_info(struct cli_state *cli, uint32_t *fs_attr)
> 	struct tevent_context *ev;
> 	struct tevent_req *req;
> 	NTSTATUS status = NT_STATUS_NO_MEMORY;
>+	TALLOC_CTX *frame = talloc_stackframe();
> 
> 	if (smbXcli_conn_has_async_calls(cli->conn)) {
> 		return NT_STATUS_INVALID_PARAMETER;
> 	}
>-	ev = samba_tevent_context_init(talloc_tos());
>+	ev = samba_tevent_context_init(frame);
> 	if (ev == NULL) {
> 		goto fail;
> 	}
>@@ -355,7 +356,7 @@ NTSTATUS cli_get_fs_attr_info(struct cli_state *cli, uint32_t *fs_attr)
> 	}
> 	status = cli_get_fs_attr_info_recv(req, fs_attr);
> fail:
>-	TALLOC_FREE(ev);
>+	TALLOC_FREE(frame);
> 	return status;
> }
> 
>@@ -437,11 +438,12 @@ NTSTATUS cli_get_fs_full_size_info(struct cli_state *cli,
> 	uint8_t *rdata = NULL;
> 	uint32_t rdata_count;
> 	NTSTATUS status;
>+	TALLOC_CTX *frame = talloc_stackframe();
> 
> 	SSVAL(setup, 0, TRANSACT2_QFSINFO);
> 	SSVAL(param, 0, SMB_FS_FULL_SIZE_INFORMATION);
> 
>-	status = cli_trans(talloc_tos(), cli, SMBtrans2,
>+	status = cli_trans(frame, cli, SMBtrans2,
> 			   NULL, 0, 0, 0,
> 			   setup, 1, 0, /* setup */
> 			   param, 2, 0,	 /* param */
>@@ -471,7 +473,7 @@ NTSTATUS cli_get_fs_full_size_info(struct cli_state *cli,
> 	}
> 
> fail:
>-	TALLOC_FREE(rdata);
>+	TALLOC_FREE(frame);
> 	return status;
> }
> 
>-- 
>1.8.4.5
>

Actions: View

Attachments on bug 11177: 10905 | 10911 | 10916