Attachment 10873 Details for Bug 10924 – Patch for master

Patch for master

0001-fsmo.py_fixed_fsmo_transfer_exception.patch (text/plain), 1.47 KB, created by Marc Muehlfeld on 2015-03-15 12:51:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Muehlfeld

Created: 2015-03-15 12:51:49 UTC

Size: 1.47 KB

patch

obsolete

>From a2fb5f4c641ebea4e83a616412a06bc49432e1de Mon Sep 17 00:00:00 2001
>From: Steve Howells <steve.howells@moscowfirst.com>
>Date: Sat, 31 Jan 2015 16:09:17 +0000
>Subject: [PATCH] s4.2/fsmo.py: fixed fsmo transfer exception
>
>In transfer_role() there is an duplicate call to samdb.modify() inside the if statement
>where the type of role is being determined (specifically for the naming fsmo). This
>call is unnecessary as after the if statement their is a correct call, with a try/catch
>block, used by all fsmo transfers that will handle errors - such as the DC with the
>fsmo role being offline.
>
>The call to samdb.modify() inside the if statement for naming fsmo has been removed.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924
>
>Signed-off-by: Steve Howells <steve.howells@moscowfirst.com>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
>
>---
> python/samba/netcmd/fsmo.py |    1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/python/samba/netcmd/fsmo.py b/python/samba/netcmd/fsmo.py
>index 02721f9..1bc4a96 100644
>--- a/python/samba/netcmd/fsmo.py
>+++ b/python/samba/netcmd/fsmo.py
>@@ -50,7 +50,6 @@ def transfer_role(outf, role, samdb):
>         m["becomeDomainMaster"]= ldb.MessageElement(
>             "1", ldb.FLAG_MOD_REPLACE,
>             "becomeDomainMaster")
>-        samdb.modify(m)
>     elif role == "infrastructure":
>         m["becomeInfrastructureMaster"]= ldb.MessageElement(
>             "1", ldb.FLAG_MOD_REPLACE,
>-- 
>1.7.10.4
>

Flags:

mmuehlfeld: review+

Actions: View

Attachments on bug 10924: 10799 | 10873 | 11112 | 11113