From a2fb5f4c641ebea4e83a616412a06bc49432e1de Mon Sep 17 00:00:00 2001 From: Steve Howells Date: Sat, 31 Jan 2015 16:09:17 +0000 Subject: [PATCH] s4.2/fsmo.py: fixed fsmo transfer exception In transfer_role() there is an duplicate call to samdb.modify() inside the if statement where the type of role is being determined (specifically for the naming fsmo). This call is unnecessary as after the if statement their is a correct call, with a try/catch block, used by all fsmo transfers that will handle errors - such as the DC with the fsmo role being offline. The call to samdb.modify() inside the if statement for naming fsmo has been removed. BUG 10924 Seizing FSMO naming role fails: WERR_CONNECTION_REFUSED Steve Howells --- python/samba/netcmd/fsmo.py | 1 - 1 file changed, 1 deletion(-) diff --git a/python/samba/netcmd/fsmo.py b/python/samba/netcmd/fsmo.py index 02721f9..1bc4a96 100644 --- a/python/samba/netcmd/fsmo.py +++ b/python/samba/netcmd/fsmo.py @@ -50,7 +50,6 @@ def transfer_role(outf, role, samdb): m["becomeDomainMaster"]= ldb.MessageElement( "1", ldb.FLAG_MOD_REPLACE, "becomeDomainMaster") - samdb.modify(m) elif role == "infrastructure": m["becomeInfrastructureMaster"]= ldb.MessageElement( "1", ldb.FLAG_MOD_REPLACE, -- 1.7.10.4