The Samba-Bugzilla – Attachment 10791 Details for
Bug 11115
S3: vfs_Chdir() is called after SMB_VFS_DISCONNECT in source3/smbd/service.c::close_cnum()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am cherry-pick from master for 4.2.0, 4.1.next, 4.0.next.
0001-smbd-Stop-using-vfs_Chdir-after-SMB_VFS_DISCONNECT.patch (text/plain), 1.31 KB, created by
Jeremy Allison
on 2015-02-25 21:59:49 UTC
(
hide
)
Description:
git-am cherry-pick from master for 4.2.0, 4.1.next, 4.0.next.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2015-02-25 21:59:49 UTC
Size:
1.31 KB
patch
obsolete
>From 7c3489de5395c8d1d34033f1a4e3047bdce78fbb Mon Sep 17 00:00:00 2001 >From: Ira Cooper <ira@samba.org> >Date: Thu, 15 Jan 2015 11:41:50 -0500 >Subject: [PATCH] smbd: Stop using vfs_Chdir after SMB_VFS_DISCONNECT. > >This sequencing is causing problems for vfs_ceph, and likely >other vfs modules. > >Signed-off-by: Ira Cooper <ira@samba.org> >Reviewed-by: Jeremy Allison <jra@samba.org> > >Autobuild-User(master): Jeremy Allison <jra@samba.org> >Autobuild-Date(master): Fri Jan 16 00:13:17 CET 2015 on sn-devel-104 > >(cherry picked from commit 81464daea71e5fa3067ec7d5f5c69c890c0f7949) >--- > source3/smbd/service.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/source3/smbd/service.c b/source3/smbd/service.c >index 19c02d6..6d31338 100644 >--- a/source3/smbd/service.c >+++ b/source3/smbd/service.c >@@ -1128,12 +1128,12 @@ void close_cnum(connection_struct *conn, uint64_t vuid) > talloc_tos()), > lp_servicename(talloc_tos(), SNUM(conn)))); > >- /* Call VFS disconnect hook */ >- SMB_VFS_DISCONNECT(conn); >- > /* make sure we leave the directory available for unmount */ > vfs_ChDir(conn, "/"); > >+ /* Call VFS disconnect hook */ >+ SMB_VFS_DISCONNECT(conn); >+ > /* execute any "postexec = " line */ > if (*lp_postexec(talloc_tos(), SNUM(conn)) && > change_to_user(conn, vuid)) { >-- >2.2.0.rc0.207.ga3a616c >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
ira
:
review+
obnox
:
review+
Actions:
View
Attachments on
bug 11115
: 10791