The Samba-Bugzilla – Attachment 10746 Details for
Bug 11103
Samba does not set the required flags in the SMB2/SMB3 Negotiate Protocol Response when signing required by client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am fix for master and 4.2.0
0001-s3-smbd-signing.-Ensure-we-respond-correctly-to-an-S.patch (text/plain), 1.77 KB, created by
Jeremy Allison
on 2015-02-19 05:29:55 UTC
(
hide
)
Description:
git-am fix for master and 4.2.0
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2015-02-19 05:29:55 UTC
Size:
1.77 KB
patch
obsolete
>From d6ecfdea8684facff9df92c75c40cd8645c119bb Mon Sep 17 00:00:00 2001 >From: Jeremy Allison <jra@samba.org> >Date: Wed, 18 Feb 2015 21:27:37 -0800 >Subject: [PATCH] s3: smbd: signing. Ensure we respond correctly to an SMB2 > negprot with SMB2_NEGOTIATE_SIGNING_REQUIRED. > >Bug 11103: - Samba does not set the required flags in the SMB2/SMB3 Negotiate Protocol Response when signing required by client > >https://bugzilla.samba.org/show_bug.cgi?id=11103 > >Signed-off-by: Jeremy Allison <jra@samba.org> >--- > source3/smbd/smb2_negprot.c | 3 ++- > source3/smbd/smb2_sesssetup.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c >index 9a1ca9c..02f6882 100644 >--- a/source3/smbd/smb2_negprot.c >+++ b/source3/smbd/smb2_negprot.c >@@ -221,7 +221,8 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req) > } > > security_mode = SMB2_NEGOTIATE_SIGNING_ENABLED; >- if (lp_server_signing() == SMB_SIGNING_REQUIRED) { >+ if (lp_server_signing() == SMB_SIGNING_REQUIRED || >+ (in_security_mode & SMB2_NEGOTIATE_SIGNING_REQUIRED)) { > security_mode |= SMB2_NEGOTIATE_SIGNING_REQUIRED; > } > >diff --git a/source3/smbd/smb2_sesssetup.c b/source3/smbd/smb2_sesssetup.c >index 2f58e44..f918328 100644 >--- a/source3/smbd/smb2_sesssetup.c >+++ b/source3/smbd/smb2_sesssetup.c >@@ -186,7 +186,9 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, > struct smbXsrv_connection *xconn = smb2req->xconn; > > if ((in_security_mode & SMB2_NEGOTIATE_SIGNING_REQUIRED) || >- lp_server_signing() == SMB_SIGNING_REQUIRED) { >+ lp_server_signing() == SMB_SIGNING_REQUIRED || >+ (xconn->smb2.server.security_mode & >+ SMB2_NEGOTIATE_SIGNING_REQUIRED)) { > x->global->signing_required = true; > } > >-- >1.9.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
sfrench
:
review+
Actions:
View
Attachments on
bug 11103
:
10744
|
10745
|
10746
|
10755
|
10756
|
10759