The Samba-Bugzilla – Attachment 10712 Details for
Bug 10808
Job missing when the queue is paused
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix for v4-0-test branch, cherry picked from mast0r
bso10808_fix_IPP_GET_JOBS_req_40t.patch (text/plain), 1.64 KB, created by
David Disseldorp
on 2015-02-10 13:07:38 UTC
(
hide
)
Description:
fix for v4-0-test branch, cherry picked from mast0r
Filename:
MIME Type:
Creator:
David Disseldorp
Created:
2015-02-10 13:07:38 UTC
Size:
1.64 KB
patch
obsolete
>From ce00105aebfd1788648504085a70513a473e625a Mon Sep 17 00:00:00 2001 >From: David Disseldorp <ddiss@samba.org> >Date: Tue, 3 Feb 2015 19:26:42 +0100 >Subject: [PATCH] printing/cups: pack requested-attributes with IPP_TAG_KEYWORD > >The CUPS IPP_GET_JOBS requested-attributes array indicates which job >attributes the caller would like in the cupsd response. > >Until now, Samba has packed these attributes with a IPP_TAG_NAME >format tag. In recent versions of CUPS, this results in the IPP_GET_JOBS >response only including the job-id and job-printer-uri fields, even with >JobPrivateValues=none configured. > >Bug: https://bugzilla.samba.org/show_bug.cgi?id=10808 > >Signed-off-by: David Disseldorp <ddiss@samba.org> >Reviewed-by: Jeremy Allison <jra@samba.org> > >Autobuild-User(master): Jeremy Allison <jra@samba.org> >Autobuild-Date(master): Tue Feb 10 01:38:58 CET 2015 on sn-devel-104 > >(cherry picked from commit 2f4998113e539ea4ba6fb0a72ba6ac25c9d74bd6) >--- > source3/printing/print_cups.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c >index 9a47843..766e35e 100644 >--- a/source3/printing/print_cups.c >+++ b/source3/printing/print_cups.c >@@ -1155,7 +1155,7 @@ static int cups_queue_get(const char *sharename, > ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE, > "attributes-natural-language", NULL, language->language); > >- ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME, >+ ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD, > "requested-attributes", > (sizeof(jattrs) / sizeof(jattrs[0])), > NULL, jattrs); >-- >2.1.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
jra
:
review+
Actions:
View
Attachments on
bug 10808
:
10278
|
10279
|
10280
|
10665
|
10696
|
10710
|
10711
| 10712