Attachment 10696 Details for Bug 10808 – Samba patch to use IPP_TAG_KEYWORD instead of IPP_TAG_NAME for IPP_GET_JOBS requested-attributes

[patch] Samba patch to use IPP_TAG_KEYWORD instead of IPP_TAG_NAME for IPP_GET_JOBS requested-attributes

0001-printing-cups-pack-requested-attributes-with-IPP_TAG.patch (text/plain), 1.40 KB, created by David Disseldorp on 2015-01-29 16:05:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2015-01-29 16:05:13 UTC

Size: 1.40 KB

patch

obsolete

>From cd2c2991be1f45c297f666e749b0286b43d0737d Mon Sep 17 00:00:00 2001
>From: David Disseldorp <ddiss@samba.org>
>Date: Thu, 29 Jan 2015 15:36:04 +0100
>Subject: [PATCH] printing/cups: pack requested-attributes with IPP_TAG_KEYWORD
>
>The CUPS IPP_GET_JOBS requested-attributes array indicates which job
>attributes the caller would like in the cupsd response.
>
>Until now, Samba has packed these attributes with a IPP_TAG_NAME
>format tag. In recent versions of CUPS, this results in the IPP_GET_JOBS
>response only including the job-id and job-printer-uri fields, even with
>JobPrivateValues=none configured.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10808
>
>Signed-off-by: David Disseldorp <ddiss@samba.org>
>---
> source3/printing/print_cups.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git source3/printing/print_cups.c source3/printing/print_cups.c
>index 68f367c..561e07d 100644
>--- source3/printing/print_cups.c
>+++ source3/printing/print_cups.c
>@@ -1157,7 +1157,7 @@ static int cups_queue_get(const char *sharename,
> 	ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
>                      "attributes-natural-language", NULL, language->language);
> 
>-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
>+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,
> 	              "requested-attributes",
> 		      (sizeof(jattrs) / sizeof(jattrs[0])),
> 		      NULL, jattrs);
>-- 
>2.1.2
>

Actions: View

Attachments on bug 10808: 10278 | 10279 | 10280 | 10665 | 10696 | 10710 | 10711 | 10712