Attachment 10654 Details for Bug 11066 – v4-1-test patch

[patch] v4-1-test patch

0001-s3-pam_smbpass-Fix-memory-leak-in-pam_sm_authenticat.patch (text/plain), 1.33 KB, created by Andreas Schneider on 2015-01-23 09:26:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2015-01-23 09:26:07 UTC

Size: 1.33 KB

patch

obsolete

>From bce805e25f540ba05833bcdd76813116b14fee55 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Thu, 22 Jan 2015 10:27:59 +0100
>Subject: [PATCH] s3-pam_smbpass: Fix memory leak in pam_sm_authenticate().
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=11066
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>(cherry picked from commit 0cb9b28acb7008cd30c6de3add9876eb5607a5a6)
>---
> source3/pam_smbpass/pam_smb_auth.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/source3/pam_smbpass/pam_smb_auth.c b/source3/pam_smbpass/pam_smb_auth.c
>index ac5ef3f..1b8ae5e 100644
>--- a/source3/pam_smbpass/pam_smb_auth.c
>+++ b/source3/pam_smbpass/pam_smb_auth.c
>@@ -41,14 +41,21 @@
> 
> #include "support.h"
> 
>+static void ret_data_cleanup(pam_handle_t *pamh, void *data, int error_status)
>+{
>+	free(data);
>+}
>+
> #define AUTH_RETURN						\
> do {								\
> 	/* Restore application signal handler */		\
> 	CatchSignal(SIGPIPE, oldsig_handler);			\
> 	if(ret_data) {						\
> 		*ret_data = retval;				\
>-		pam_set_data( pamh, "smb_setcred_return"	\
>-		              , (void *) ret_data, NULL );	\
>+		pam_set_data(pamh,				\
>+			"smb_setcred_return",			\
>+			(void *)ret_data,			\
>+			ret_data_cleanup);			\
> 	}							\
> 	TALLOC_FREE(frame);					\
> 	return retval;						\
>-- 
>2.2.2
>

Flags:

jra: review+

Actions: View

Attachments on bug 11066: 10653 | 10654