The Samba-Bugzilla – Attachment 10616 Details for
Bug 11008
Authentication fails when netbios/hostname is longer than MAX_NETBIOSNAME_LEN-1
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
v4-2-test patch
0001-s3-util-Fix-authentication-with-long-hostnames.patch (text/plain), 1.07 KB, created by
Andreas Schneider
on 2015-01-13 17:14:51 UTC
(
hide
)
Description:
v4-2-test patch
Filename:
MIME Type:
Creator:
Andreas Schneider
Created:
2015-01-13 17:14:51 UTC
Size:
1.07 KB
patch
obsolete
>From fe7ddf1b0fd3535f353b538b40d383c833aaf228 Mon Sep 17 00:00:00 2001 >From: Andreas Schneider <asn@samba.org> >Date: Mon, 12 Jan 2015 18:12:13 +0100 >Subject: [PATCH] s3-util: Fix authentication with long hostnames. > >If the hostname is longer than MAX_NETBIOSNAME_LEN we fail to correctly >check the hostname. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=11008 > >Signed-off-by: Andreas Schneider <asn@samba.org> >Reviewed-by: Jeremy Allison <jra@samba.org> > >(cherry picked from commit da2611adef32107f5a0eec97501c01232ab72efc) >Signed-off-by: Andreas Schneider <asn@samba.org> >--- > source3/lib/util.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/source3/lib/util.c b/source3/lib/util.c >index 7b2afa8..bd57db2 100644 >--- a/source3/lib/util.c >+++ b/source3/lib/util.c >@@ -1195,7 +1195,9 @@ bool is_myname(const char *s) > bool ret = False; > > for (n=0; my_netbios_names(n); n++) { >- if (strequal(my_netbios_names(n), s)) { >+ const char *nbt_name = my_netbios_names(n); >+ >+ if (strncasecmp_m(nbt_name, s, strlen(nbt_name)) == 0) { > ret=True; > break; > } >-- >2.2.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
jra
:
review+
Actions:
View
Attachments on
bug 11008
: 10616 |
10617