Attachment 10614 Details for Bug 11051 – Patch for 4.1

[patch] Patch for 4.1

11051-4.1 (text/plain), 1.60 KB, created by Volker Lendecke on 2015-01-13 14:47:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2015-01-13 14:47:32 UTC

Size: 1.60 KB

patch

obsolete

>From fc48a1fd6e8f644bb3ea759364e7f47843ceaeba Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Tue, 13 Jan 2015 12:51:13 +0100
>Subject: [PATCH] net: Fix sam addgroupmem
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Domain local groups come across as SID_TYPE_ALIAS and are sent to us in the
>PAC/Info3 struct. We should allow this in net sam addgroupmem.
>
>Volker
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Guenther Deschner <gd@samba.org>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=11051
>
>Autobuild-User(master): GÃ¼nther Deschner <gd@samba.org>
>Autobuild-Date(master): Tue Jan 13 15:28:16 CET 2015 on sn-devel-104
>---
> source3/utils/net_sam.c |    8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/source3/utils/net_sam.c b/source3/utils/net_sam.c
>index b7b76e8..7c314af 100644
>--- a/source3/utils/net_sam.c
>+++ b/source3/utils/net_sam.c
>@@ -1216,10 +1216,12 @@ static int net_sam_addmem(struct net_context *c, int argc, const char **argv)
> 
> 	if ((grouptype == SID_NAME_ALIAS) || (grouptype == SID_NAME_WKN_GRP)) {
> 		if ((membertype != SID_NAME_USER) &&
>+		    (membertype != SID_NAME_ALIAS) &&
> 		    (membertype != SID_NAME_DOM_GRP)) {
>-			d_fprintf(stderr, _("%s is a local group, only users "
>-				  "and domain groups can be added.\n"
>-				  "%s is a %s\n"), argv[0], argv[1],
>+			d_fprintf(stderr, _("Can't add %s: only users, domain "
>+					    "groups and domain local groups "
>+					    "can be added. %s is a %s\n"),
>+				  argv[0], argv[1],
> 				  sid_type_lookup(membertype));
> 			return -1;
> 		}
>-- 
>1.7.9.5
>

Flags:

gd: review+

Actions: View

Attachments on bug 11051: 10613 | 10614 | 10615