Attachment 10594 Details for Bug 10583 – Patch against 4.1 to avoid reloading printers on SIGHUP or MSG_SMB_CONF_UPDATED

[patch] Patch against 4.1 to avoid reloading printers on SIGHUP or MSG_SMB_CONF_UPDATED

0001-spoolss-don-t-reload-printers-on-SIGHUP-or-MSG_SMB_C.patch (text/plain), 1.31 KB, created by David Disseldorp on 2015-01-08 14:49:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2015-01-08 14:49:41 UTC

Size: 1.31 KB

patch

obsolete

>From ca215bfbf766ac91fb46fe85a21988cd1cac4ba3 Mon Sep 17 00:00:00 2001
>From: David Disseldorp <ddiss@samba.org>
>Date: Thu, 8 Jan 2015 15:22:44 +0100
>Subject: [PATCH] spoolss: don't reload printers on SIGHUP or
> MSG_SMB_CONF_UPDATED
>
>Printers are reloaded on client enumeration, so needn't be done on
>conf update.
>
>Signed-off-by: David Disseldorp <ddiss@samba.org>
>---
> source3/printing/spoolssd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git source3/printing/spoolssd.c source3/printing/spoolssd.c
>index 59f560c..d25eb27 100644
>--- source3/printing/spoolssd.c
>+++ source3/printing/spoolssd.c
>@@ -108,7 +108,6 @@ static void update_conf(struct tevent_context *ev,
> {
> 	change_to_root_user();
> 	lp_load(get_dyn_CONFIGFILE(), true, false, false, true);
>-	load_printers(ev, msg);
> 
> 	spoolss_reopen_logs(spoolss_child_id);
> 	if (spoolss_child_id == 0) {
>@@ -220,9 +219,8 @@ static void spoolss_chld_sig_hup_handler(struct tevent_context *ev,
> 	msg_ctx = talloc_get_type_abort(pvt, struct messaging_context);
> 
> 	change_to_root_user();
>-	DEBUG(1,("Reloading printers after SIGHUP\n"));
>-	load_printers(ev, msg_ctx);
> 	spoolss_reopen_logs(spoolss_child_id);
>+	/* printers are reloaded on client enumeration, no need to do it here */
> }
> 
> static bool spoolss_setup_chld_hup_handler(struct tevent_context *ev_ctx,
>-- 
>2.1.2
>

Actions: View

Attachments on bug 10583: 9892 | 9893 | 10594