From 0e704803a3f92a79aa7bc908dabb8b29aa9cdd1b Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 17 Dec 2014 10:43:33 +0100 Subject: [PATCH] s3:locking: fix uninitialiazed variable in brl_get_locks_readonly_parser() In a cluster this can be called with an empty record, while brl_parse_data() relies on an initialized structure. This is a regression in commit 837e29035c911f3509135252c3f423d0f56b606d. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10911 Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme Reviewed-by: Jeremy Allison (cherry picked from commit 6bc41c459f6da7de62d2113590bc7d0c2d04e136) --- source3/locking/brlock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source3/locking/brlock.c b/source3/locking/brlock.c index b7dcb41..7d4d838 100644 --- a/source3/locking/brlock.c +++ b/source3/locking/brlock.c @@ -2005,6 +2005,7 @@ static void brl_get_locks_readonly_parser(TDB_DATA key, TDB_DATA data, *state->br_lock = NULL; return; } + *br_lck = (struct byte_range_lock) {}; if (!brl_parse_data(br_lck, data)) { *state->br_lock = NULL; return; -- 1.9.1