Attachment 10485 Details for Bug 10982 – Proposed patchset for master.

[patch] Proposed patchset for master.

fallocate-fix (text/plain), 7.96 KB, created by Jeremy Allison on 2014-12-04 19:53:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2014-12-04 19:53:54 UTC

Size: 7.96 KB

patch

obsolete

>From e26605faac1b50f271bfaaf5c1dfa058b27faf12 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 4 Dec 2014 11:16:17 -0800
>Subject: [PATCH 1/3] s3: smbd: Fix VFS FALLOCATE call.
>
>The current SMB_VFS_FALLOCATE() is a mess. Some code paths
>return -1 and set errno on failure, some return errno on
>failure and the calling code doesn't differentiate
>correctly.
>
>Standardize on the POSIX return -1 and set errno on failure.
>
>Based on initial work from Jones <jones.kstw@gmail.com>.
>
>https://bugzilla.samba.org/show_bug.cgi?id=10982
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> source3/modules/vfs_default.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
>diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c
>index 2ac7100..bdcb005 100644
>--- a/source3/modules/vfs_default.c
>+++ b/source3/modules/vfs_default.c
>@@ -1853,15 +1853,14 @@ static int strict_allocate_ftruncate(vfs_handle_struct *handle, files_struct *fs
> 	   return ENOTSUP or EINVAL in cases like that. */
> 	ret = SMB_VFS_FALLOCATE(fsp, VFS_FALLOCATE_EXTEND_SIZE,
> 				pst->st_ex_size, space_to_write);
>-	if (ret == ENOSPC) {
>-		errno = ENOSPC;
>+	if (ret == -1 && errno == ENOSPC) {
> 		return -1;
> 	}
> 	if (ret == 0) {
> 		return 0;
> 	}
> 	DEBUG(10,("strict_allocate_ftruncate: SMB_VFS_FALLOCATE failed with "
>-		"error %d. Falling back to slow manual allocation\n", ret));
>+		"error %d. Falling back to slow manual allocation\n", errno));
> 
> 	/* available disk space is enough or not? */
> 	space_avail = get_dfree_info(fsp->conn,
>@@ -1877,8 +1876,7 @@ static int strict_allocate_ftruncate(vfs_handle_struct *handle, files_struct *fs
> 	/* Write out the real space on disk. */
> 	ret = vfs_slow_fallocate(fsp, pst->st_ex_size, space_to_write);
> 	if (ret != 0) {
>-		errno = ret;
>-		ret = -1;
>+		return -1;
> 	}
> 
> 	return 0;
>@@ -1963,6 +1961,15 @@ static int vfswrap_fallocate(vfs_handle_struct *handle,
> 	START_PROFILE(syscall_fallocate);
> 	if (mode == VFS_FALLOCATE_EXTEND_SIZE) {
> 		result = sys_posix_fallocate(fsp->fh->fd, offset, len);
>+		/*
>+		 * posix_fallocate returns 0 on success, errno on error
>+		 * and doesn't set errno. Make it behave like fallocate()
>+		 * which returns -1, and sets errno on failure.
>+		 */
>+		if (result != 0) {
>+			errno = result;
>+			result = -1;
>+		}
> 	} else if (mode == VFS_FALLOCATE_KEEP_SIZE) {
> 		result = sys_fallocate(fsp->fh->fd, mode, offset, len);
> 	} else {
>-- 
>2.2.0.rc0.207.ga3a616c
>
>
>From 58f53038fca76fc70b6ec87cf1c83f2f026df97e Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 4 Dec 2014 11:19:15 -0800
>Subject: [PATCH 2/3] s3: smbd: Fix VFS FALLOCATE call (part2).
>
>Standardize on the POSIX return -1 and set errno on failure.
>
>Based on initial work from Jones <jones.kstw@gmail.com>.
>
>https://bugzilla.samba.org/show_bug.cgi?id=10982
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> source3/smbd/vfs.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
>diff --git a/source3/smbd/vfs.c b/source3/smbd/vfs.c
>index 8e33f2d..3a9e84b 100644
>--- a/source3/smbd/vfs.c
>+++ b/source3/smbd/vfs.c
>@@ -574,6 +574,9 @@ int vfs_allocate_file_space(files_struct *fsp, uint64_t len)
> 		/* See if we have a syscall that will allocate beyond
> 		   end-of-file without changing EOF. */
> 		ret = SMB_VFS_FALLOCATE(fsp, VFS_FALLOCATE_KEEP_SIZE, 0, len);
>+		if (ret == -1 && errno == ENOSPC) {
>+			return -1;
>+		}
> 	} else {
> 		ret = 0;
> 	}
>@@ -640,7 +643,7 @@ int vfs_set_filelen(files_struct *fsp, off_t len)
>  fails. Needs to be outside of the default version of SMB_VFS_FALLOCATE
>  as this is also called from the default SMB_VFS_FTRUNCATE code.
>  Always extends the file size.
>- Returns 0 on success, errno on failure.
>+ Returns 0 on success, -1 on failure.
> ****************************************************************************/
> 
> #define SPARSE_BUF_WRITE_SIZE (32*1024)
>@@ -654,7 +657,7 @@ int vfs_slow_fallocate(files_struct *fsp, off_t offset, off_t len)
> 		sparse_buf = SMB_CALLOC_ARRAY(char, SPARSE_BUF_WRITE_SIZE);
> 		if (!sparse_buf) {
> 			errno = ENOMEM;
>-			return ENOMEM;
>+			return -1;
> 		}
> 	}
> 
>@@ -663,10 +666,12 @@ int vfs_slow_fallocate(files_struct *fsp, off_t offset, off_t len)
> 
> 		pwrite_ret = SMB_VFS_PWRITE(fsp, sparse_buf, curr_write_size, offset + total);
> 		if (pwrite_ret == -1) {
>+			int saved_errno = errno;
> 			DEBUG(10,("vfs_slow_fallocate: SMB_VFS_PWRITE for file "
> 				  "%s failed with error %s\n",
>-				  fsp_str_dbg(fsp), strerror(errno)));
>-			return errno;
>+				  fsp_str_dbg(fsp), strerror(saved_errno)));
>+			errno = saved_errno;
>+			return -1;
> 		}
> 		total += pwrite_ret;
> 	}
>@@ -724,9 +729,7 @@ int vfs_fill_sparse(files_struct *fsp, off_t len)
> 		 * return ENOTSUP or EINVAL in cases like that. */
> 		ret = SMB_VFS_FALLOCATE(fsp, VFS_FALLOCATE_EXTEND_SIZE,
> 				offset, num_to_write);
>-		if (ret == ENOSPC) {
>-			errno = ENOSPC;
>-			ret = -1;
>+		if (ret == -1 && errno == ENOSPC) {
> 			goto out;
> 		}
> 		if (ret == 0) {
>@@ -737,10 +740,6 @@ int vfs_fill_sparse(files_struct *fsp, off_t len)
> 	}
> 
> 	ret = vfs_slow_fallocate(fsp, offset, num_to_write);
>-	if (ret != 0) {
>-		errno = ret;
>-		ret = -1;
>-	}
> 
>  out:
> 
>-- 
>2.2.0.rc0.207.ga3a616c
>
>
>From b5c18a3e89dfd24407743876c5c12a4503843cda Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 4 Dec 2014 11:19:47 -0800
>Subject: [PATCH 3/3] s3: smbd: Fix VFS FALLOCATE call (part3).
>
>Standardize on the POSIX return -1 and set errno on failure.
>
>Fix all the VFS modules to have the same convention.
>
>Based on initial work from Jones <jones.kstw@gmail.com>.
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> source3/modules/vfs_ceph.c          | 13 +++----------
> source3/modules/vfs_fruit.c         |  5 +++--
> source3/modules/vfs_streams_xattr.c |  5 +++--
> 3 files changed, 9 insertions(+), 14 deletions(-)
>
>diff --git a/source3/modules/vfs_ceph.c b/source3/modules/vfs_ceph.c
>index e402ff1..b0a0024 100644
>--- a/source3/modules/vfs_ceph.c
>+++ b/source3/modules/vfs_ceph.c
>@@ -795,15 +795,14 @@ static int strict_allocate_ftruncate(struct vfs_handle_struct *handle, files_str
> 	   return ENOTSUP or EINVAL in cases like that. */
> 	ret = SMB_VFS_FALLOCATE(fsp, VFS_FALLOCATE_EXTEND_SIZE,
> 				pst->st_ex_size, space_to_write);
>-	if (ret == ENOSPC) {
>-		errno = ENOSPC;
>+	if (ret == -1 && errno == ENOSPC) {
> 		return -1;
> 	}
> 	if (ret == 0) {
> 		return 0;
> 	}
> 	DEBUG(10,("[CEPH] strict_allocate_ftruncate: SMB_VFS_FALLOCATE failed with "
>-		"error %d. Falling back to slow manual allocation\n", ret));
>+		"error %d. Falling back to slow manual allocation\n", errno));
> 
> 	/* available disk space is enough or not? */
> 	space_avail = get_dfree_info(fsp->conn,
>@@ -817,13 +816,7 @@ static int strict_allocate_ftruncate(struct vfs_handle_struct *handle, files_str
> 	}
> 
> 	/* Write out the real space on disk. */
>-	ret = vfs_slow_fallocate(fsp, pst->st_ex_size, space_to_write);
>-	if (ret != 0) {
>-		errno = ret;
>-		ret = -1;
>-	}
>-
>-	return 0;
>+	return vfs_slow_fallocate(fsp, pst->st_ex_size, space_to_write);
> }
> 
> static int cephwrap_ftruncate(struct vfs_handle_struct *handle, files_struct *fsp, off_t len)
>diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
>index da1ec7f..647d024 100644
>--- a/source3/modules/vfs_fruit.c
>+++ b/source3/modules/vfs_fruit.c
>@@ -2790,11 +2790,12 @@ static int fruit_fallocate(struct vfs_handle_struct *handle,
> 	}
> 
> 	if (!fruit_fsp_recheck(ad, fsp)) {
>-		return errno;
>+		return -1;
> 	}
> 
> 	/* Let the pwrite code path handle it. */
>-	return ENOSYS;
>+	errno = ENOSYS;
>+	return -1;
> }
> 
> static int fruit_ftruncate(struct vfs_handle_struct *handle,
>diff --git a/source3/modules/vfs_streams_xattr.c b/source3/modules/vfs_streams_xattr.c
>index f0ab732..5c5a9a1 100644
>--- a/source3/modules/vfs_streams_xattr.c
>+++ b/source3/modules/vfs_streams_xattr.c
>@@ -1103,11 +1103,12 @@ static int streams_xattr_fallocate(struct vfs_handle_struct *handle,
> 	}
> 
> 	if (!streams_xattr_recheck(sio)) {
>-		return errno;
>+		return -1;
> 	}
> 
> 	/* Let the pwrite code path handle it. */
>-	return ENOSYS;
>+	errno = ENOSYS;
>+	return -1;
> }
> 
> 
>-- 
>2.2.0.rc0.207.ga3a616c
>

Actions: View

Attachments on bug 10982: 10480 | 10485 | 10496 | 10499 | 10500 | 10501