Attachment 10466 Details for Bug 10966 – git-am fix for 4.1.next - backport from master

[patch] git-am fix for 4.1.next - backport from master

0001-libcli-SMB2-Pure-SMB2-only-negprot-fix-to-make-us-be.patch (text/plain), 1.95 KB, created by Jeremy Allison on 2014-11-26 21:47:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2014-11-26 21:47:36 UTC

Size: 1.95 KB

patch

obsolete

>From 2778f83718dc17252edd01445d70ad2bace034c1 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Wed, 26 Nov 2014 13:33:57 -0800
>Subject: [PATCH] libcli: SMB2: Pure SMB2-only negprot fix to make us behave as
> a Windows client does.
>
>Required as some servers return zero when asked for
>zero credits in an initial SMB2-only negprot.
>
>Back-port of c426f97238e4f664d1b13781101ca9c942aa7d0d
>from master.
>
>https://bugzilla.samba.org/show_bug.cgi?id=10966
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> libcli/smb/smbXcli_base.c | 11 +++++++++++
> source3/include/local.h   |  2 ++
> 2 files changed, 13 insertions(+)
>
>diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
>index 25fbabd..0ceb1dd 100644
>--- a/libcli/smb/smbXcli_base.c
>+++ b/libcli/smb/smbXcli_base.c
>@@ -31,6 +31,7 @@
> #include "../libcli/smb/read_smb.h"
> #include "smbXcli_base.h"
> #include "librpc/ndr/libndr.h"
>+#include "local.h"
> 
> struct smbXcli_conn;
> struct smbXcli_req;
>@@ -3791,6 +3792,16 @@ struct tevent_req *smbXcli_negprot_send(TALLOC_CTX *mem_ctx,
> 		 */
> 		conn->dispatch_incoming = smb2cli_conn_dispatch_incoming;
> 
>+		/*
>+		 * As we're starting with an SMB2 negprot, emulate Windows
>+		 * and ask for 31 credits in the initial SMB2 negprot.
>+		 * If we don't and leave requested credits at
>+		 * zero, MacOSX servers return zero credits on
>+		 * the negprot reply and we fail to connect.
>+		 */
>+		smb2cli_conn_set_max_credits(conn,
>+			WINDOWS_CLIENT_PURE_SMB2_NEGPROT_INITIAL_CREDIT_ASK);
>+
> 		subreq = smbXcli_negprot_smb2_subreq(state);
> 		if (tevent_req_nomem(subreq, req)) {
> 			return tevent_req_post(req, ev);
>diff --git a/source3/include/local.h b/source3/include/local.h
>index a87ab8f..5ea7960 100644
>--- a/source3/include/local.h
>+++ b/source3/include/local.h
>@@ -217,4 +217,6 @@
> #define DEFAULT_SMB2_MAX_TRANSACT (1024*1024)
> #define DEFAULT_SMB2_MAX_CREDITS 8192
> 
>+#define WINDOWS_CLIENT_PURE_SMB2_NEGPROT_INITIAL_CREDIT_ASK	31
>+
> #endif
>-- 
>2.2.0.rc0.207.ga3a616c
>

Flags:

slow: review+

Actions: View

Attachments on bug 10966: 10465 | 10466