Index: lib/util_str.c =================================================================== --- lib/util_str.c (revision 5865) +++ lib/util_str.c (working copy) @@ -365,14 +365,14 @@ void string_replace(pstring s,char oldc,char newc) { - unsigned char *p; + char *p; /* this is quite a common operation, so we want it to be fast. We optimise for the ascii case, knowing that all our supported multi-byte character sets are ascii-compatible (ie. they match for the first 128 chars) */ - for (p = (unsigned char *)s; *p; p++) { + for (p = s; *p; p++) { if (*p & 0x80) /* mb string - slow path. */ break; if (*p == oldc)