The Samba-Bugzilla – Attachment 10457 Details for
Bug 10961
smbstatus --profile always returns failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
v4-2-test patch
0002-s3-smbstatus-Fix-exit-code-of-profile-output.patch (text/plain), 1.22 KB, created by
Andreas Schneider
on 2014-11-25 14:06:13 UTC
(
hide
)
Description:
v4-2-test patch
Filename:
MIME Type:
Creator:
Andreas Schneider
Created:
2014-11-25 14:06:13 UTC
Size:
1.22 KB
patch
obsolete
>From a01d4b38b1095c498fd0dedbbfe09ce42d6207e3 Mon Sep 17 00:00:00 2001 >From: Andreas Schneider <asn@samba.org> >Date: Mon, 24 Nov 2014 17:46:27 +0100 >Subject: [PATCH 2/2] s3-smbstatus: Fix exit code of profile output. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=10961 > >Signed-off-by: Andreas Schneider <asn@samba.org> >Reviewed-by: Jeremy Allison <jra@samba.org> >--- > source3/utils/status.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/source3/utils/status.c b/source3/utils/status.c >index 9cb4d8b..2c21ee4 100644 >--- a/source3/utils/status.c >+++ b/source3/utils/status.c >@@ -365,6 +365,7 @@ int main(int argc, const char *argv[]) > TALLOC_CTX *frame = talloc_stackframe(); > int ret = 0; > struct messaging_context *msg_ctx; >+ bool ok; > > sec_init(); > load_case_tables(); >@@ -464,10 +465,12 @@ int main(int argc, const char *argv[]) > switch (profile_only) { > case 'P': > /* Dump profile data */ >- return status_profile_dump(verbose); >+ ok = status_profile_dump(verbose); >+ return ok ? 0 : 1; > case 'R': > /* Continuously display rate-converted data */ >- return status_profile_rates(verbose); >+ ok = status_profile_rates(verbose); >+ return ok ? 0 : 1; > default: > break; > } >-- >2.1.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
jra
:
review+
Actions:
View
Attachments on
bug 10961
: 10457 |
10459