Attachment 10420 Details for Bug 10921 – Fixed patch for 4.1.next, 4.0.next.

[patch] Fixed patch for 4.1.next, 4.0.next.

0001-s3-smbd-fix-file-corruption-using-write-cache-size-0.patch (text/plain), 1016 bytes, created by Jeremy Allison on 2014-11-08 00:00:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2014-11-08 00:00:44 UTC

Size: 1016 bytes

patch

obsolete

>From a0040ad74e82bf322a4a69ae687d5669a27f6b9e Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Fri, 7 Nov 2014 15:57:40 -0800
>Subject: [PATCH] s3:smbd: fix file corruption using "write cache size != 0"
>
>A client can:
>- open a handle (h1)
>- write some data to h1.
>- open a 2nd handle h2 (downgrades both handles to level II)
>- try to read the data on h2 (this gets old data)
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10921
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>---
> source3/smbd/oplock.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
>index f2d39b8..ed4de13 100644
>--- a/source3/smbd/oplock.c
>+++ b/source3/smbd/oplock.c
>@@ -151,6 +151,9 @@ static void downgrade_file_oplock(files_struct *fsp)
> 	sconn->oplocks.level_II_open++;
> 	fsp->sent_oplock_break = NO_BREAK_SENT;
> 
>+	flush_write_cache(fsp, OPLOCK_RELEASE_FLUSH);
>+	delete_write_cache(fsp);
>+
> 	TALLOC_FREE(fsp->oplock_timeout);
> }
> 
>-- 
>2.1.0.rc2.206.gedb03e5
>

Flags:

metze: review+

Actions: View

Attachments on bug 10921: 10413 | 10420