Attachment 10413 Details for Bug 10921 – Patch for master

[patch] Patch for master

tmp.diff.txt (text/plain), 1005 bytes, created by Stefan Metzmacher on 2014-11-06 08:26:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2014-11-06 08:26:04 UTC

Size: 1005 bytes

patch

obsolete

>From 8b6fa2c138d1ef207df0fed84b0acf2fb12ce891 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Thu, 6 Nov 2014 09:23:46 +0100
>Subject: [PATCH] s3:smbd: fix file corruption using "write cache size != 0"
>
>A client can:
>- open a handle (h1)
>- write some data to h1.
>- open a 2nd handle h2 (downgrades both handles to level II)
>- try to read the data on h2 (this gets old data)
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10921
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>---
> source3/smbd/oplock.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
>index 17cb22e..7935092 100644
>--- a/source3/smbd/oplock.c
>+++ b/source3/smbd/oplock.c
>@@ -142,6 +142,9 @@ static void downgrade_file_oplock(files_struct *fsp)
> 	sconn->oplocks.level_II_open++;
> 	fsp->sent_oplock_break = NO_BREAK_SENT;
> 
>+	flush_write_cache(fsp, SAMBA_OPLOCK_RELEASE_FLUSH);
>+	delete_write_cache(fsp);
>+
> 	TALLOC_FREE(fsp->oplock_timeout);
> }
> 
>-- 
>1.9.1
>

Flags:

jra: review+
metze: review+

Actions: View

Attachments on bug 10921: 10413 | 10420