From 1d0a2c3b760c4da038abd878fc65e279a5bd8876 Mon Sep 17 00:00:00 2001 From: Richard Sharpe Date: Mon, 22 Jul 2013 16:04:43 -0700 Subject: [PATCH] There are tests all over the SMB1 code to check that srv_send_smb fails, but it never returns false. Even if the write to the socket/fd fails, we never return false and will keep reading stuff off of the input buffer until it is exhausted and then we will exit. Signed-off-by: Richard Sharpe Reviewed-by: Jeremy Allison Autobuild-User(master): Richard Sharpe Autobuild-Date(master): Sat Aug 3 17:41:22 CEST 2013 on sn-devel-104 (cherry picked from commit 852c9ac34dbef66d0b2619554c611157c2fab771) --- source3/smbd/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/smbd/process.c b/source3/smbd/process.c index 45bde2f..d01bf39 100644 --- a/source3/smbd/process.c +++ b/source3/smbd/process.c @@ -201,7 +201,7 @@ out: SMB_PERFCOUNT_END(pcd); smbd_unlock_socket(sconn); - return true; + return (ret > 0); } /******************************************************************* -- 2.1.0.rc2.206.gedb03e5