Attachment 10359 Details for Bug 10852 – 4.2 patch cherry-picked from master

[patch] 4.2 patch cherry-picked from master

0001-winbind3-Fix-pwent-variable-substitution.patch (text/plain), 1.07 KB, created by Andrew Bartlett on 2014-10-20 22:19:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2014-10-20 22:19:51 UTC

Size: 1.07 KB

patch

obsolete

>From 9bb222c3cb22367c556744aac75e3e9759a5a1e3 Mon Sep 17 00:00:00 2001
>From: Justin Maggard <jmaggard10@gmail.com>
>Date: Thu, 2 Oct 2014 17:21:06 -0700
>Subject: [PATCH] winbind3: Fix pwent variable substitution
>
>Commit 0ce46318 (winbind3: Simplify fillup_pw_field) broke variable
>substitution by copying from the wrong (unsubstituted) buffer.  Fix it.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=10852
>Signed-off-by: Justin Maggard <jmaggard10@gmail.com>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: Richard Sharpe <rsharpe@samba.org>
>(cherry picked from commit 902086d0d4c688236ad4a8248a50de8639e1e524)
>---
> source3/winbindd/wb_fill_pwent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/winbindd/wb_fill_pwent.c b/source3/winbindd/wb_fill_pwent.c
>index 206827c..1135ef3 100644
>--- a/source3/winbindd/wb_fill_pwent.c
>+++ b/source3/winbindd/wb_fill_pwent.c
>@@ -240,7 +240,7 @@ static bool fillup_pw_field(const char *lp_template,
> 		return False;
> 	}
> 
>-	fstrcpy(out, templ);
>+	fstrcpy(out, result);
> 	TALLOC_FREE(result);
> 
> 	return True;
>-- 
>2.1.1
>

Flags:

jra: review+

Actions: View

Attachments on bug 10852: 10324 | 10359