Attachment 10284 Details for Bug 10813 – Patch

[patch] Patch

10813.patch (text/plain), 1.33 KB, created by Volker Lendecke on 2014-09-12 06:27:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2014-09-12 06:27:43 UTC

Size: 1.33 KB

patch

obsolete

>From de496b5969b506fe861a0fb6d640e95bc6843c0d Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Thu, 11 Sep 2014 11:33:42 +0000
>Subject: [PATCH] media_harmony: Fix a crash bug
>
>Now that the dust has settled, fix a crash bug that was hidden behind
>the warnings...
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10813
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Simo Sorce <idra@samba.org>
>Reviewed-by: Michael Adam <obnox@samba.org>
>
>Autobuild-User(master): Michael Adam <obnox@samba.org>
>Autobuild-Date(master): Fri Sep 12 02:45:40 CEST 2014 on sn-devel-104
>---
> source3/modules/vfs_media_harmony.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/modules/vfs_media_harmony.c b/source3/modules/vfs_media_harmony.c
>index ce981e8..eedbc95 100644
>--- a/source3/modules/vfs_media_harmony.c
>+++ b/source3/modules/vfs_media_harmony.c
>@@ -492,8 +492,8 @@ static int alloc_get_client_smb_fname(struct vfs_handle_struct *handle,
> 	DEBUG(MH_INFO_DEBUG, ("Entering with smb_fname->base_name '%s'\n",
> 			      smb_fname->base_name));
> 
>-	clientFname = cp_smb_filename(ctx, smb_fname);
>-	if (clientFname == NULL) {
>+	*clientFname = cp_smb_filename(ctx, smb_fname);
>+	if ((*clientFname) == NULL) {
> 		DEBUG(MH_ERR_DEBUG, ("alloc_get_client_smb_fname "
> 					"NTERR\n"));
> 		errno = ENOMEM;
>-- 
>1.7.9.5
>

Flags:

obnox: review+

Actions: View

Attachments on bug 10813: 10284