From bcfae2dd4f5936c1b2c36fa8e62426b20cc29522 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 4 Sep 2014 12:55:53 +0200 Subject: [PATCH] selftest: Fix selftest where pid is used uninitialized. On my system this gets evaluated to 0 so in the end we detect samba to be running cause $childpid is set to 0. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10793 Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Thu Sep 4 17:09:17 CEST 2014 on sn-devel-104 (cherry picked from commit 6d2f56dbaf84203b351f33179cc3feaf557e0683) Signed-off-by: Andreas Schneider --- selftest/target/Samba.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/selftest/target/Samba.pm b/selftest/target/Samba.pm index d811053..5f18a47 100644 --- a/selftest/target/Samba.pm +++ b/selftest/target/Samba.pm @@ -186,7 +186,12 @@ sub get_interface($) sub cleanup_child($$) { my ($pid, $name) = @_; - my $childpid = waitpid($pid, WNOHANG); + my $childpid = -1; + + if (defined($pid)) { + $childpid = waitpid($pid, WNOHANG); + } + if ($childpid == 0) { } elsif ($childpid < 0) { printf STDERR "%s child process %d isn't here any more\n", -- 2.1.0