Attachment 10222 Details for Bug 10777 – git-am fix for 4.1.next and 4.0.next.

[patch] git-am fix for 4.1.next and 4.0.next.

0001-Don-t-discard-result-of-checking-grouptype.patch (text/plain), 1.19 KB, created by Jeremy Allison on 2014-08-25 18:54:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2014-08-25 18:54:52 UTC

Size: 1.19 KB

patch

obsolete

>From 6174bfafe7c8d3e424869c08077ae1deb002de03 Mon Sep 17 00:00:00 2001
>From: Roel van Meer <roel@1afa.com>
>Date: Fri, 22 Aug 2014 15:11:04 +0200
>Subject: [PATCH] Don't discard result of checking grouptype
>
>The pdb_samba_dsdb_getgrfilter() function first determines the security type
>of a group and sets map->sid_name_use accordingly. A little later, this
>variable is set again, undoing the previous work.
>
>https://bugzilla.samba.org/show_bug.cgi?id=10777
>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: Simo Sorce <idra@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Sat Aug 23 02:48:52 CEST 2014 on sn-devel-104
>---
> source3/passdb/pdb_samba_dsdb.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
>index b04e7b2..87320e8 100644
>--- a/source3/passdb/pdb_samba_dsdb.c
>+++ b/source3/passdb/pdb_samba_dsdb.c
>@@ -944,8 +944,6 @@ static NTSTATUS pdb_samba_dsdb_getgrfilter(struct pdb_methods *m, GROUP_MAP *map
> 			return NT_STATUS_INTERNAL_DB_CORRUPTION;
> 		}
> 
>-		map->sid_name_use = SID_NAME_DOM_GRP;
>-
> 		ZERO_STRUCT(id_map);
> 		id_map.sid = sid;
> 		id_maps[0] = &id_map;
>-- 
>2.1.0.rc2.206.gedb03e5
>

Flags:

jra: review? (idra)
jra: review? (metze)
ddiss: review+

Actions: View

Attachments on bug 10777: 10216 | 10222