Attachment 10199 Details for Bug 10759 – git-am fix for 4.1.next and 4.0.next.

[patch] git-am fix for 4.1.next and 4.0.next.

0001-Fixed-a-memory-leak-in-cli_set_mntpoint.patch (text/plain), 1.41 KB, created by Jeremy Allison on 2014-08-13 17:40:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2014-08-13 17:40:54 UTC

Size: 1.41 KB

patch

obsolete

>From f34ffd0d0993f997f2b4e3b992338def367cc49b Mon Sep 17 00:00:00 2001
>From: Har Gagan Sahai <SHarGagan@novell.com>
>Date: Wed, 6 Aug 2014 14:32:35 +0530
>Subject: [PATCH] Fixed a memory leak in cli_set_mntpoint().
>
>Fixes bug #10759 - Memory leak in libsmbclient in cli_set_mntpoint function
>
>https://bugzilla.samba.org/show_bug.cgi?id=10759
>
>Signed-off-by: Har Gagan Sahai <SHarGagan@novell.com>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Wed Aug 13 04:36:50 CEST 2014 on sn-devel-104
>---
> source3/libsmb/clidfs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c
>index 80fba23..93f04c5 100644
>--- a/source3/libsmb/clidfs.c
>+++ b/source3/libsmb/clidfs.c
>@@ -280,13 +280,15 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
> 
> static void cli_set_mntpoint(struct cli_state *cli, const char *mnt)
> {
>-	char *name = clean_name(NULL, mnt);
>+	TALLOC_CTX *frame = talloc_stackframe();
>+	char *name = clean_name(frame, mnt);
> 	if (!name) {
>+		TALLOC_FREE(frame);
> 		return;
> 	}
> 	TALLOC_FREE(cli->dfs_mountpoint);
> 	cli->dfs_mountpoint = talloc_strdup(cli, name);
>-	TALLOC_FREE(name);
>+	TALLOC_FREE(frame);
> }
> 
> /********************************************************************
>-- 
>2.1.0.rc2.206.gedb03e5
>

Flags:

vl: review+

Actions: View

Attachments on bug 10759: 10177 | 10178 | 10199