The Samba-Bugzilla – Attachment 10177 Details for
Bug 10759
Memory leak in libsmbclient in cli_set_mntpoint function
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch fixing the issue of memory leak in cli_set_mntpoint() in libsmbclient.so
memory_leak_cli_mnt_point.diff (text/plain), 673 bytes, created by
hargagan
on 2014-08-06 06:34:05 UTC
(
hide
)
Description:
Proposed patch fixing the issue of memory leak in cli_set_mntpoint() in libsmbclient.so
Filename:
MIME Type:
Creator:
hargagan
Created:
2014-08-06 06:34:05 UTC
Size:
673 bytes
patch
obsolete
>diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c >index 80fba23..1713275d 100644 >--- a/source3/libsmb/clidfs.c >+++ b/source3/libsmb/clidfs.c >@@ -280,13 +280,15 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx, > > static void cli_set_mntpoint(struct cli_state *cli, const char *mnt) > { >- char *name = clean_name(NULL, mnt); >+ TALLOC_CTX *frame = talloc_stackframe(); >+ char *name = clean_name(frame, mnt); > if (!name) { >+ TALLOC_FREE(frame); > return; > } > TALLOC_FREE(cli->dfs_mountpoint); > cli->dfs_mountpoint = talloc_strdup(cli, name); >- TALLOC_FREE(name); >+ TALLOC_FREE(frame); > } > > /********************************************************************
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=10177">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 10759
:
10177
|
10178
|
10199